From 42f8495f59297585f3d3ae55e9b7e3f16b203a9a Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Mon, 9 Mar 2026 00:32:14 -0700 Subject: [PATCH] fix: add nil/empty group validation in postgres store Guard CreateGroup and UpdateGroup against nil group or empty name to prevent panics from nil member access and empty-name row inserts. --- weed/credential/postgres/postgres_group.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/weed/credential/postgres/postgres_group.go b/weed/credential/postgres/postgres_group.go index 0cf361ab6..dca8c6817 100644 --- a/weed/credential/postgres/postgres_group.go +++ b/weed/credential/postgres/postgres_group.go @@ -13,6 +13,9 @@ import ( ) func (store *PostgresStore) CreateGroup(ctx context.Context, group *iam_pb.Group) error { + if group == nil || group.Name == "" { + return fmt.Errorf("group name is required") + } membersJSON, err := json.Marshal(group.Members) if err != nil { return fmt.Errorf("failed to marshal members: %w", err) @@ -95,6 +98,9 @@ func (store *PostgresStore) ListGroups(ctx context.Context) ([]string, error) { } func (store *PostgresStore) UpdateGroup(ctx context.Context, group *iam_pb.Group) error { + if group == nil || group.Name == "" { + return fmt.Errorf("group name is required") + } membersJSON, err := json.Marshal(group.Members) if err != nil { return fmt.Errorf("failed to marshal members: %w", err)