From 36d11f3cb3eeb9090a275117a7e702a10143be4a Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sun, 8 Mar 2026 21:20:06 -0700 Subject: [PATCH] fix: add nil guard for group param in propagating store log calls Prevent potential nil dereference when logging group.Name in CreateGroup and UpdateGroup of PropagatingCredentialStore. --- weed/credential/propagating_store.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/weed/credential/propagating_store.go b/weed/credential/propagating_store.go index 86ba48d74..141890747 100644 --- a/weed/credential/propagating_store.go +++ b/weed/credential/propagating_store.go @@ -391,7 +391,9 @@ func (s *PropagatingCredentialStore) DeleteServiceAccount(ctx context.Context, i // via the filer subscription mechanism (watching /etc/iam/groups/ directory). func (s *PropagatingCredentialStore) CreateGroup(ctx context.Context, group *iam_pb.Group) error { - glog.V(4).Infof("IAM: PropagatingCredentialStore.CreateGroup %s", group.Name) + if group != nil { + glog.V(4).Infof("IAM: PropagatingCredentialStore.CreateGroup %s", group.Name) + } return s.CredentialStore.CreateGroup(ctx, group) } @@ -409,6 +411,8 @@ func (s *PropagatingCredentialStore) ListGroups(ctx context.Context) ([]string, } func (s *PropagatingCredentialStore) UpdateGroup(ctx context.Context, group *iam_pb.Group) error { - glog.V(4).Infof("IAM: PropagatingCredentialStore.UpdateGroup %s", group.Name) + if group != nil { + glog.V(4).Infof("IAM: PropagatingCredentialStore.UpdateGroup %s", group.Name) + } return s.CredentialStore.UpdateGroup(ctx, group) }