avoid leaking grpc.NewClientStream

5 years ago · 1ea9bc66d9
1 changed files with 3 additions and 1 deletions
--- a/weed/pb/filer_pb/filer_client.go
+++ b/weed/pb/filer_pb/filer_client.go
@ -83,10 +83,12 @@ func doList(filerClient FilerClient, fullDirPath util.FullPath, prefix string, f
 		}

 		glog.V(3).Infof("read directory: %v", request)
-		stream, err := client.ListEntries(context.Background(), request)
+		ctx, cancel := context.WithCancel(context.Background())
+		stream, err := client.ListEntries(ctx, request)
 		if err != nil {
 			return fmt.Errorf("list %s: %v", fullDirPath, err)
 		}
+		defer cancel()

 		var prevEntry *Entry
 		for {