Browse Source

Document ReadFilerConf HA limitation in lifecycle handlers

Addresses review comment on s3api_bucket_handlers.go:880

Add comment documenting that ReadFilerConf uses the current active filer
from FilerClient (which is better than always using first filer), but
doesn't have built-in multi-filer failover.

Add TODO to update filer.ReadFilerConf to support multiple filers for
complete HA. For now, it uses the currently active/healthy filer tracked
by FilerClient which provides reasonable availability.
pull/7550/head
Chris Lu 4 days ago
parent
commit
1d7fded503
  1. 3
      weed/s3api/s3api_bucket_handlers.go

3
weed/s3api/s3api_bucket_handlers.go

@ -877,6 +877,9 @@ func (s3a *S3ApiServer) GetBucketLifecycleConfigurationHandler(w http.ResponseWr
s3err.WriteErrorResponse(w, r, err)
return
}
// Note: ReadFilerConf uses current active filer from FilerClient
// If this filer becomes unavailable, the request will fail
// TODO: Make ReadFilerConf support multi-filer failover
fc, err := filer.ReadFilerConf(s3a.getFilerAddress(), s3a.option.GrpcDialOption, nil)
if err != nil {
glog.Errorf("GetBucketLifecycleConfigurationHandler: %s", err)

Loading…
Cancel
Save