From 19bd91be85e5343b5302c6e980d7d13dae907fb2 Mon Sep 17 00:00:00 2001
From: chrislu <chris.lu@gmail.com>
Date: Thu, 6 Nov 2025 22:41:32 -0800
Subject: [PATCH] pagination, one transaction for deletion

---
 weed/filer/foundationdb/foundationdb_store.go | 44 ++++++++++++++-----
 1 file changed, 33 insertions(+), 11 deletions(-)

diff --git a/weed/filer/foundationdb/foundationdb_store.go b/weed/filer/foundationdb/foundationdb_store.go
index b7df8a7eb..52e6b7502 100644
--- a/weed/filer/foundationdb/foundationdb_store.go
+++ b/weed/filer/foundationdb/foundationdb_store.go
@@ -95,7 +95,9 @@ func (store *FoundationDBStore) initialize(clusterFile string, apiVersion int) e
 	glog.V(0).Infof("FoundationDB: connecting to cluster file: %s, API version: %d", clusterFile, apiVersion)
 
 	// Set FDB API version
-	fdb.MustAPIVersion(apiVersion)
+	if err := fdb.APIVersion(apiVersion); err != nil {
+		return fmt.Errorf("failed to set FoundationDB API version %d: %w", apiVersion, err)
+	}
 
 	// Open database
 	var err error
@@ -272,24 +274,44 @@ func (store *FoundationDBStore) DeleteFolderChildren(ctx context.Context, fullpa
 	// We need recursion because our key structure is tuple{dirPath, fileName}
 	// not tuple{dirPath, ...pathComponents}, so a simple prefix range won't catch subdirectories
 
-	return store.deleteFolderChildrenRecursive(ctx, fullpath)
+	// Wrap entire deletion in a single transaction for performance
+	if _, exists := store.getTransactionFromContext(ctx); exists {
+		return store.deleteFolderChildrenRecursive(ctx, fullpath)
+	}
+
+	_, err := store.database.Transact(func(tr fdb.Transaction) (interface{}, error) {
+		txCtx := store.setTransactionInContext(context.Background(), tr)
+		return nil, store.deleteFolderChildrenRecursive(txCtx, fullpath)
+	})
+
+	return err
 }
 
 func (store *FoundationDBStore) deleteFolderChildrenRecursive(ctx context.Context, fullpath util.FullPath) error {
-	// List all entries in this directory
+	// List all entries in this directory (with pagination for directories > 1000 entries)
 	var entriesToDelete []util.FullPath
 	var subDirectories []util.FullPath
 
-	err := store.ListDirectoryEntries(ctx, fullpath, "", true, MAX_DIRECTORY_LIST_LIMIT, func(entry *filer.Entry) bool {
-		entriesToDelete = append(entriesToDelete, entry.FullPath)
-		if entry.IsDirectory() {
-			subDirectories = append(subDirectories, entry.FullPath)
+	var startFileName string
+	inclusive := true
+	for {
+		lastFileName, err := store.ListDirectoryEntries(ctx, fullpath, startFileName, inclusive, MAX_DIRECTORY_LIST_LIMIT, func(entry *filer.Entry) bool {
+			entriesToDelete = append(entriesToDelete, entry.FullPath)
+			if entry.IsDirectory() {
+				subDirectories = append(subDirectories, entry.FullPath)
+			}
+			return true
+		})
+
+		if err != nil {
+			return fmt.Errorf("listing children of %s: %w", fullpath, err)
 		}
-		return true
-	})
 
-	if err != nil {
-		return fmt.Errorf("listing children of %s: %w", fullpath, err)
+		if lastFileName == "" {
+			break
+		}
+		startFileName = lastFileName
+		inclusive = false
 	}
 
 	// Recursively delete subdirectories first