From 0e00a1db703c2a18d267efa12814e02a663f6e4a Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sun, 8 Mar 2026 23:50:20 -0700 Subject: [PATCH] fix: check DeleteEntry response error when cleaning obsolete group files Capture and log resp.Error from filer DeleteEntry calls during group file cleanup, matching the pattern used in deleteGroupFile. --- weed/credential/filer_etc/filer_etc_identity.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/weed/credential/filer_etc/filer_etc_identity.go b/weed/credential/filer_etc/filer_etc_identity.go index 4046a934a..9c4900ab1 100644 --- a/weed/credential/filer_etc/filer_etc_identity.go +++ b/weed/credential/filer_etc/filer_etc_identity.go @@ -271,11 +271,14 @@ func (store *FilerEtcStore) SaveConfiguration(ctx context.Context, config *iam_p for _, entry := range entries { if !entry.IsDirectory && !validNames[entry.Name] { - if _, err := client.DeleteEntry(ctx, &filer_pb.DeleteEntryRequest{ + resp, err := client.DeleteEntry(ctx, &filer_pb.DeleteEntryRequest{ Directory: dir, Name: entry.Name, - }); err != nil { + }) + if err != nil { glog.Warningf("Failed to delete obsolete group file %s: %v", entry.Name, err) + } else if resp != nil && resp.Error != "" { + glog.Warningf("Failed to delete obsolete group file %s: %s", entry.Name, resp.Error) } } }