Browse Source
S3 API: Fix SSE-S3 decryption on object download (#7366)
S3 API: Fix SSE-S3 decryption on object download (#7366)
* S3 API: Fix SSE-S3 decryption on object download Fixes #7363 This commit adds missing SSE-S3 decryption support when downloading objects from SSE-S3 encrypted buckets. Previously, SSE-S3 encrypted objects were returned in their encrypted form, causing data corruption and hash mismatches. Changes: - Updated detectPrimarySSEType() to detect SSE-S3 encrypted objects by examining chunk metadata and distinguishing SSE-S3 from SSE-KMS - Added SSE-S3 handling in handleSSEResponse() to route to new handler - Implemented handleSSES3Response() for both single-part and multipart SSE-S3 encrypted objects with proper decryption - Implemented createMultipartSSES3DecryptedReader() for multipart objects with per-chunk decryption using stored IVs - Updated addSSEHeadersToResponse() to include SSE-S3 response headers The fix follows the existing SSE-C and SSE-KMS patterns, using the envelope encryption architecture where each object's DEK is encrypted with the KEK stored in the filer. * Add comprehensive tests for SSE-S3 decryption - TestSSES3EncryptionDecryption: basic encryption/decryption - TestSSES3IsRequestInternal: request detection - TestSSES3MetadataSerialization: metadata serialization/deserialization - TestDetectPrimarySSETypeS3: SSE type detection for various scenarios - TestAddSSES3HeadersToResponse: response header validation - TestSSES3EncryptionWithBaseIV: multipart encryption with base IV - TestSSES3WrongKeyDecryption: wrong key error handling - TestSSES3KeyGeneration: key generation and uniqueness - TestSSES3VariousSizes: encryption/decryption with various data sizes - TestSSES3ResponseHeaders: response header correctness - TestSSES3IsEncryptedInternal: metadata-based encryption detection - TestSSES3InvalidMetadataDeserialization: error handling for invalid metadata - TestGetSSES3Headers: header generation - TestProcessSSES3Request: request processing - TestGetSSES3KeyFromMetadata: key extraction from metadata - TestSSES3EnvelopeEncryption: envelope encryption correctness - TestValidateSSES3Key: key validation All tests pass successfully, providing comprehensive coverage for the SSE-S3 decryption fix. * Address PR review comments 1. Fix resource leak in createMultipartSSES3DecryptedReader: - Wrap decrypted reader with closer to properly release resources - Ensure underlying chunkReader is closed when done 2. Handle mixed-encryption objects correctly: - Check chunk encryption type before attempting decryption - Pass through non-SSE-S3 chunks unmodified - Log encryption type for debugging 3. Improve SSE type detection logic: - Add explicit case for aws:kms algorithm - Handle unknown algorithms gracefully - Better documentation for tie-breaking precedence 4. Document tie-breaking behavior: - Clarify that mixed encryption indicates potential corruption - Explicit precedence order: SSE-C > SSE-KMS > SSE-S3 These changes address high-severity resource management issues and improve robustness when handling edge cases and mixed-encryption scenarios. * Fix IV retrieval for small/inline SSE-S3 encrypted files Critical bug fix: The previous implementation only looked for the IV in chunk metadata, which would fail for small files stored inline (without chunks). Changes: - Check object-level metadata (sseS3Key.IV) first for inline files - Fallback to first chunk metadata only if object-level IV not found - Improved error message to indicate both locations were checked This ensures small SSE-S3 encrypted files (stored inline in entry.Content) can be properly decrypted, as their IV is stored in the object-level SeaweedFSSSES3Key metadata rather than in chunk metadata. Fixes the high-severity issue identified in PR review. * Clean up unused SSE metadata helper functions Remove legacy SSE metadata helper functions that were never fully implemented or used: Removed unused functions: - StoreSSECMetadata() / GetSSECMetadata() - StoreSSEKMSMetadata() / GetSSEKMSMetadata() - StoreSSES3Metadata() / GetSSES3Metadata() - IsSSEEncrypted() - GetSSEAlgorithm() Removed unused constants: - MetaSSEAlgorithm - MetaSSECKeyMD5 - MetaSSEKMSKeyID - MetaSSEKMSEncryptedKey - MetaSSEKMSContext - MetaSSES3KeyID These functions were from an earlier design where IV and other metadata would be stored in common entry.Extended keys. The actual implementations use type-specific serialization: - SSE-C: Uses StoreIVInMetadata()/GetIVFromMetadata() directly for IV - SSE-KMS: Serializes entire SSEKMSKey structure as JSON (includes IV) - SSE-S3: Serializes entire SSES3Key structure as JSON (includes IV) This follows Option A: SSE-S3 uses envelope encryption pattern like SSE-KMS, where IV is stored within the serialized key metadata rather than in a separate metadata field. Kept functions still in use: - StoreIVInMetadata() - Used by SSE-C - GetIVFromMetadata() - Used by SSE-C and streaming copy - MetaSSEIV constant - Used by SSE-C All tests pass after cleanup. * Rename SSE metadata functions to clarify SSE-C specific usage Renamed functions and constants to explicitly indicate they are SSE-C specific, improving code clarity: Renamed: - MetaSSEIV → MetaSSECIV - StoreIVInMetadata() → StoreSSECIVInMetadata() - GetIVFromMetadata() → GetSSECIVFromMetadata() Updated all usages across: - s3api_key_rotation.go - s3api_streaming_copy.go - s3api_object_handlers_copy.go - s3_sse_copy_test.go - s3_sse_test_utils_test.go Rationale: These functions are exclusively used by SSE-C for storing/retrieving the IV in entry.Extended metadata. SSE-KMS and SSE-S3 use different approaches (IV stored in serialized key structures), so the generic names were misleading. The new names make it clear these are part of the SSE-C implementation. All tests pass. * Add integration tests for SSE-S3 end-to-end encryption/decryption These integration tests cover the complete encrypt->store->decrypt cycle that was missing from the original test suite. They would have caught the IV retrieval bug for inline files. Tests added: - TestSSES3EndToEndSmallFile: Tests inline files (10, 50, 256 bytes) * Specifically tests the critical IV retrieval path for inline files * This test explicitly checks the bug we fixed where inline files couldn't retrieve their IV from object-level metadata - TestSSES3EndToEndChunkedFile: Tests multipart encrypted files * Verifies per-chunk metadata serialization/deserialization * Tests that each chunk can be independently decrypted with its own IV - TestSSES3EndToEndWithDetectPrimaryType: Tests type detection * Verifies inline vs chunked SSE-S3 detection * Ensures SSE-S3 is distinguished from SSE-KMS Note: Full HTTP handler tests (PUT -> GET through actual handlers) would require a complete mock server with filer connections, which is complex. These tests focus on the critical decrypt path and data flow. Why these tests are important: - Unit tests alone don't catch integration issues - The IV retrieval bug existed because there was no end-to-end test - These tests simulate the actual storage/retrieval flow - They verify the complete encryption architecture works correctly All tests pass. * Fix TestValidateSSES3Key expectations to match actual implementation The ValidateSSES3Key function only validates that the key struct is not nil, but doesn't validate the Key field contents or size. The test was expecting validation that doesn't exist. Updated test cases: - Nil key struct → should error (correct) - Valid key → should not error (correct) - Invalid key size → should not error (validation doesn't check this) - Nil key bytes → should not error (validation doesn't check this) Added comments to clarify what the current validation actually checks. This matches the behavior of ValidateSSEKMSKey and ValidateSSECKey which also only check for nil struct, not field contents. All SSE tests now pass. * Improve ValidateSSES3Key to properly validate key contents Enhanced the validation function from only checking nil struct to comprehensive validation of all key fields: Validations added: 1. Key bytes not nil 2. Key size exactly 32 bytes (SSES3KeySize) 3. Algorithm must be "AES256" (SSES3Algorithm) 4. Key ID must not be empty 5. IV length must be 16 bytes if set (optional - set during encryption) Test improvements (10 test cases): - Nil key struct - Valid key without IV - Valid key with IV - Invalid key size (too small) - Invalid key size (too large) - Nil key bytes - Empty key ID - Invalid algorithm - Invalid IV length - Empty IV (allowed - set during encryption) This matches the robustness of SSE-C and SSE-KMS validation and will catch configuration errors early rather than failing during encryption/decryption. All SSE tests pass. * Replace custom string helper functions with strings.Contains Address Gemini Code Assist review feedback: - Remove custom contains() and findSubstring() helper functions - Use standard library strings.Contains() instead - Add strings import This makes the code more idiomatic and easier to maintain by using the standard library instead of reimplementing functionality. Changes: - Added "strings" to imports - Replaced contains(err.Error(), tc.errorMsg) with strings.Contains(err.Error(), tc.errorMsg) - Removed 15 lines of custom helper code All tests pass. * filer fix reading and writing SSE-S3 headers * filter out seaweedfs internal headers * Update weed/s3api/s3api_object_handlers.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update weed/s3api/s3_validation_utils.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update s3api_streaming_copy.go * remove fallback * remove redundant check * refactor * remove extra object fetching * in case object is not found * Correct Version Entry for SSE Routing * Proper Error Handling for SSE Entry Fetching * Eliminated All Redundant Lookups * Removed brittle “exactly 5 successes/failures” assertions. Added invariant checks total recorded attempts equals request count, successes never exceed capacity, failures cover remaining attempts, final AvailableSpace matches capacity - successes. * refactor * fix test * Fixed Broken Fallback Logic * refactor * Better Error for Encryption Type Mismatch * refactor --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>pull/7378/head
Chris Lu
5 days ago
committed by
GitHub
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
17 changed files with 1762 additions and 256 deletions
-
10weed/s3api/s3_constants/header.go
-
3weed/s3api/s3_sse_c_range_test.go
-
2weed/s3api/s3_sse_copy_test.go
-
152weed/s3api/s3_sse_metadata.go
-
25weed/s3api/s3_sse_s3.go
-
325weed/s3api/s3_sse_s3_integration_test.go
-
984weed/s3api/s3_sse_s3_test.go
-
2weed/s3api/s3_sse_test_utils_test.go
-
27weed/s3api/s3_validation_utils.go
-
6weed/s3api/s3api_key_rotation.go
-
407weed/s3api/s3api_object_handlers.go
-
8weed/s3api/s3api_object_handlers_copy.go
-
10weed/s3api/s3api_streaming_copy.go
-
6weed/s3api/s3err/s3api_errors.go
-
9weed/server/filer_server_handlers_read.go
-
10weed/server/filer_server_handlers_write_autochunk.go
-
32weed/topology/volume_growth_reservation_test.go
@ -0,0 +1,325 @@ |
|||
package s3api |
|||
|
|||
import ( |
|||
"bytes" |
|||
"io" |
|||
"testing" |
|||
|
|||
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb" |
|||
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants" |
|||
) |
|||
|
|||
// NOTE: These are integration tests that test the end-to-end encryption/decryption flow.
|
|||
// Full HTTP handler tests (PUT -> GET) would require a complete mock server with filer,
|
|||
// which is complex to set up. These tests focus on the critical decrypt path.
|
|||
|
|||
// TestSSES3EndToEndSmallFile tests the complete encryption->storage->decryption cycle for small inline files
|
|||
// This test would have caught the IV retrieval bug for inline files
|
|||
func TestSSES3EndToEndSmallFile(t *testing.T) { |
|||
// Initialize global SSE-S3 key manager
|
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
defer func() { |
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
}() |
|||
|
|||
// Set up the key manager with a super key for testing
|
|||
keyManager := GetSSES3KeyManager() |
|||
keyManager.superKey = make([]byte, 32) |
|||
for i := range keyManager.superKey { |
|||
keyManager.superKey[i] = byte(i) |
|||
} |
|||
|
|||
testCases := []struct { |
|||
name string |
|||
data []byte |
|||
}{ |
|||
{"tiny file (10 bytes)", []byte("test12345")}, |
|||
{"small file (50 bytes)", []byte("This is a small test file for SSE-S3 encryption")}, |
|||
{"medium file (256 bytes)", bytes.Repeat([]byte("a"), 256)}, |
|||
} |
|||
|
|||
for _, tc := range testCases { |
|||
t.Run(tc.name, func(t *testing.T) { |
|||
// Step 1: Encrypt (simulates what happens during PUT)
|
|||
sseS3Key, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key: %v", err) |
|||
} |
|||
|
|||
encryptedReader, iv, err := CreateSSES3EncryptedReader(bytes.NewReader(tc.data), sseS3Key) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create encrypted reader: %v", err) |
|||
} |
|||
|
|||
encryptedData, err := io.ReadAll(encryptedReader) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read encrypted data: %v", err) |
|||
} |
|||
|
|||
// Store IV in the key (this is critical for inline files!)
|
|||
sseS3Key.IV = iv |
|||
|
|||
// Serialize the metadata (this is stored in entry.Extended)
|
|||
serializedMetadata, err := SerializeSSES3Metadata(sseS3Key) |
|||
if err != nil { |
|||
t.Fatalf("Failed to serialize SSE-S3 metadata: %v", err) |
|||
} |
|||
|
|||
// Step 2: Simulate storage (inline file - no chunks)
|
|||
// For inline files, data is in Content, metadata in Extended
|
|||
mockEntry := &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.SeaweedFSSSES3Key: serializedMetadata, |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Content: encryptedData, |
|||
Chunks: []*filer_pb.FileChunk{}, // Critical: inline files have NO chunks
|
|||
} |
|||
|
|||
// Step 3: Decrypt (simulates what happens during GET)
|
|||
// This tests the IV retrieval path for inline files
|
|||
|
|||
// First, deserialize metadata from storage
|
|||
retrievedKeyData := mockEntry.Extended[s3_constants.SeaweedFSSSES3Key] |
|||
retrievedKey, err := DeserializeSSES3Metadata(retrievedKeyData, keyManager) |
|||
if err != nil { |
|||
t.Fatalf("Failed to deserialize SSE-S3 metadata: %v", err) |
|||
} |
|||
|
|||
// CRITICAL TEST: For inline files, IV must be in object-level metadata
|
|||
var retrievedIV []byte |
|||
if len(retrievedKey.IV) > 0 { |
|||
// Success path: IV found in object-level key
|
|||
retrievedIV = retrievedKey.IV |
|||
} else if len(mockEntry.GetChunks()) > 0 { |
|||
// Fallback path: would check chunks (but inline files have no chunks)
|
|||
t.Fatal("Inline file should have IV in object-level metadata, not chunks") |
|||
} |
|||
|
|||
if len(retrievedIV) == 0 { |
|||
// THIS IS THE BUG WE FIXED: inline files had no way to get IV!
|
|||
t.Fatal("Failed to retrieve IV for inline file - this is the bug we fixed!") |
|||
} |
|||
|
|||
// Now decrypt with the retrieved IV
|
|||
decryptedReader, err := CreateSSES3DecryptedReader(bytes.NewReader(encryptedData), retrievedKey, retrievedIV) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create decrypted reader: %v", err) |
|||
} |
|||
|
|||
decryptedData, err := io.ReadAll(decryptedReader) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read decrypted data: %v", err) |
|||
} |
|||
|
|||
// Verify decrypted data matches original
|
|||
if !bytes.Equal(decryptedData, tc.data) { |
|||
t.Errorf("Decrypted data doesn't match original.\nExpected: %q\nGot: %q", tc.data, decryptedData) |
|||
} |
|||
}) |
|||
} |
|||
} |
|||
|
|||
// TestSSES3EndToEndChunkedFile tests the complete flow for chunked files
|
|||
func TestSSES3EndToEndChunkedFile(t *testing.T) { |
|||
// Initialize global SSE-S3 key manager
|
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
defer func() { |
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
}() |
|||
|
|||
keyManager := GetSSES3KeyManager() |
|||
keyManager.superKey = make([]byte, 32) |
|||
for i := range keyManager.superKey { |
|||
keyManager.superKey[i] = byte(i) |
|||
} |
|||
|
|||
// Generate SSE-S3 key
|
|||
sseS3Key, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key: %v", err) |
|||
} |
|||
|
|||
// Create test data for two chunks
|
|||
chunk1Data := []byte("This is chunk 1 data for SSE-S3 encryption test") |
|||
chunk2Data := []byte("This is chunk 2 data for SSE-S3 encryption test") |
|||
|
|||
// Encrypt chunk 1
|
|||
encryptedReader1, iv1, err := CreateSSES3EncryptedReader(bytes.NewReader(chunk1Data), sseS3Key) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create encrypted reader for chunk 1: %v", err) |
|||
} |
|||
encryptedChunk1, _ := io.ReadAll(encryptedReader1) |
|||
|
|||
// Encrypt chunk 2
|
|||
encryptedReader2, iv2, err := CreateSSES3EncryptedReader(bytes.NewReader(chunk2Data), sseS3Key) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create encrypted reader for chunk 2: %v", err) |
|||
} |
|||
encryptedChunk2, _ := io.ReadAll(encryptedReader2) |
|||
|
|||
// Create metadata for each chunk
|
|||
chunk1Key := &SSES3Key{ |
|||
Key: sseS3Key.Key, |
|||
IV: iv1, |
|||
Algorithm: sseS3Key.Algorithm, |
|||
KeyID: sseS3Key.KeyID, |
|||
} |
|||
chunk2Key := &SSES3Key{ |
|||
Key: sseS3Key.Key, |
|||
IV: iv2, |
|||
Algorithm: sseS3Key.Algorithm, |
|||
KeyID: sseS3Key.KeyID, |
|||
} |
|||
|
|||
serializedChunk1Meta, _ := SerializeSSES3Metadata(chunk1Key) |
|||
serializedChunk2Meta, _ := SerializeSSES3Metadata(chunk2Key) |
|||
serializedObjMeta, _ := SerializeSSES3Metadata(sseS3Key) |
|||
|
|||
// Create mock entry with chunks
|
|||
mockEntry := &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.SeaweedFSSSES3Key: serializedObjMeta, |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Chunks: []*filer_pb.FileChunk{ |
|||
{ |
|||
FileId: "chunk1,123", |
|||
Offset: 0, |
|||
Size: uint64(len(encryptedChunk1)), |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: serializedChunk1Meta, |
|||
}, |
|||
{ |
|||
FileId: "chunk2,456", |
|||
Offset: int64(len(chunk1Data)), |
|||
Size: uint64(len(encryptedChunk2)), |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: serializedChunk2Meta, |
|||
}, |
|||
}, |
|||
} |
|||
|
|||
// Verify multipart detection
|
|||
sses3Chunks := 0 |
|||
for _, chunk := range mockEntry.GetChunks() { |
|||
if chunk.GetSseType() == filer_pb.SSEType_SSE_S3 && len(chunk.GetSseMetadata()) > 0 { |
|||
sses3Chunks++ |
|||
} |
|||
} |
|||
|
|||
isMultipart := sses3Chunks > 1 |
|||
if !isMultipart { |
|||
t.Error("Expected multipart SSE-S3 object detection") |
|||
} |
|||
|
|||
if sses3Chunks != 2 { |
|||
t.Errorf("Expected 2 SSE-S3 chunks, got %d", sses3Chunks) |
|||
} |
|||
|
|||
// Verify each chunk has valid metadata with IV
|
|||
for i, chunk := range mockEntry.GetChunks() { |
|||
deserializedKey, err := DeserializeSSES3Metadata(chunk.GetSseMetadata(), keyManager) |
|||
if err != nil { |
|||
t.Errorf("Failed to deserialize chunk %d metadata: %v", i, err) |
|||
} |
|||
if len(deserializedKey.IV) == 0 { |
|||
t.Errorf("Chunk %d has no IV", i) |
|||
} |
|||
|
|||
// Decrypt this chunk to verify it works
|
|||
var chunkData []byte |
|||
if i == 0 { |
|||
chunkData = encryptedChunk1 |
|||
} else { |
|||
chunkData = encryptedChunk2 |
|||
} |
|||
|
|||
decryptedReader, err := CreateSSES3DecryptedReader(bytes.NewReader(chunkData), deserializedKey, deserializedKey.IV) |
|||
if err != nil { |
|||
t.Errorf("Failed to decrypt chunk %d: %v", i, err) |
|||
continue |
|||
} |
|||
|
|||
decrypted, _ := io.ReadAll(decryptedReader) |
|||
var expectedData []byte |
|||
if i == 0 { |
|||
expectedData = chunk1Data |
|||
} else { |
|||
expectedData = chunk2Data |
|||
} |
|||
|
|||
if !bytes.Equal(decrypted, expectedData) { |
|||
t.Errorf("Chunk %d decryption failed", i) |
|||
} |
|||
} |
|||
} |
|||
|
|||
// TestSSES3EndToEndWithDetectPrimaryType tests that type detection works correctly for different scenarios
|
|||
func TestSSES3EndToEndWithDetectPrimaryType(t *testing.T) { |
|||
s3a := &S3ApiServer{} |
|||
|
|||
testCases := []struct { |
|||
name string |
|||
entry *filer_pb.Entry |
|||
expectedType string |
|||
shouldBeSSES3 bool |
|||
}{ |
|||
{ |
|||
name: "Inline SSE-S3 file (no chunks)", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Content: []byte("encrypted data"), |
|||
Chunks: []*filer_pb.FileChunk{}, |
|||
}, |
|||
expectedType: s3_constants.SSETypeS3, |
|||
shouldBeSSES3: true, |
|||
}, |
|||
{ |
|||
name: "Single chunk SSE-S3 file", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{ |
|||
{ |
|||
FileId: "1,123", |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: []byte("metadata"), |
|||
}, |
|||
}, |
|||
}, |
|||
expectedType: s3_constants.SSETypeS3, |
|||
shouldBeSSES3: true, |
|||
}, |
|||
{ |
|||
name: "SSE-KMS file (has KMS key ID)", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
s3_constants.AmzServerSideEncryptionAwsKmsKeyId: []byte("kms-key-123"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{}, |
|||
}, |
|||
expectedType: s3_constants.SSETypeKMS, |
|||
shouldBeSSES3: false, |
|||
}, |
|||
} |
|||
|
|||
for _, tc := range testCases { |
|||
t.Run(tc.name, func(t *testing.T) { |
|||
detectedType := s3a.detectPrimarySSEType(tc.entry) |
|||
if detectedType != tc.expectedType { |
|||
t.Errorf("Expected type %s, got %s", tc.expectedType, detectedType) |
|||
} |
|||
if (detectedType == s3_constants.SSETypeS3) != tc.shouldBeSSES3 { |
|||
t.Errorf("SSE-S3 detection mismatch: expected %v, got %v", tc.shouldBeSSES3, detectedType == s3_constants.SSETypeS3) |
|||
} |
|||
}) |
|||
} |
|||
} |
|||
@ -0,0 +1,984 @@ |
|||
package s3api |
|||
|
|||
import ( |
|||
"bytes" |
|||
"fmt" |
|||
"io" |
|||
"net/http" |
|||
"net/http/httptest" |
|||
"strings" |
|||
"testing" |
|||
|
|||
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb" |
|||
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants" |
|||
) |
|||
|
|||
// TestSSES3EncryptionDecryption tests basic SSE-S3 encryption and decryption
|
|||
func TestSSES3EncryptionDecryption(t *testing.T) { |
|||
// Generate SSE-S3 key
|
|||
sseS3Key, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key: %v", err) |
|||
} |
|||
|
|||
// Test data
|
|||
testData := []byte("Hello, World! This is a test of SSE-S3 encryption.") |
|||
|
|||
// Create encrypted reader
|
|||
dataReader := bytes.NewReader(testData) |
|||
encryptedReader, iv, err := CreateSSES3EncryptedReader(dataReader, sseS3Key) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create encrypted reader: %v", err) |
|||
} |
|||
|
|||
// Read encrypted data
|
|||
encryptedData, err := io.ReadAll(encryptedReader) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read encrypted data: %v", err) |
|||
} |
|||
|
|||
// Verify data is actually encrypted (different from original)
|
|||
if bytes.Equal(encryptedData, testData) { |
|||
t.Error("Data doesn't appear to be encrypted") |
|||
} |
|||
|
|||
// Create decrypted reader
|
|||
encryptedReader2 := bytes.NewReader(encryptedData) |
|||
decryptedReader, err := CreateSSES3DecryptedReader(encryptedReader2, sseS3Key, iv) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create decrypted reader: %v", err) |
|||
} |
|||
|
|||
// Read decrypted data
|
|||
decryptedData, err := io.ReadAll(decryptedReader) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read decrypted data: %v", err) |
|||
} |
|||
|
|||
// Verify decrypted data matches original
|
|||
if !bytes.Equal(decryptedData, testData) { |
|||
t.Errorf("Decrypted data doesn't match original.\nOriginal: %s\nDecrypted: %s", testData, decryptedData) |
|||
} |
|||
} |
|||
|
|||
// TestSSES3IsRequestInternal tests detection of SSE-S3 requests
|
|||
func TestSSES3IsRequestInternal(t *testing.T) { |
|||
testCases := []struct { |
|||
name string |
|||
headers map[string]string |
|||
expected bool |
|||
}{ |
|||
{ |
|||
name: "Valid SSE-S3 request", |
|||
headers: map[string]string{ |
|||
s3_constants.AmzServerSideEncryption: "AES256", |
|||
}, |
|||
expected: true, |
|||
}, |
|||
{ |
|||
name: "No SSE headers", |
|||
headers: map[string]string{}, |
|||
expected: false, |
|||
}, |
|||
{ |
|||
name: "SSE-KMS request", |
|||
headers: map[string]string{ |
|||
s3_constants.AmzServerSideEncryption: "aws:kms", |
|||
}, |
|||
expected: false, |
|||
}, |
|||
{ |
|||
name: "SSE-C request", |
|||
headers: map[string]string{ |
|||
s3_constants.AmzServerSideEncryptionCustomerAlgorithm: "AES256", |
|||
}, |
|||
expected: false, |
|||
}, |
|||
} |
|||
|
|||
for _, tc := range testCases { |
|||
t.Run(tc.name, func(t *testing.T) { |
|||
req := &http.Request{Header: make(http.Header)} |
|||
for k, v := range tc.headers { |
|||
req.Header.Set(k, v) |
|||
} |
|||
|
|||
result := IsSSES3RequestInternal(req) |
|||
if result != tc.expected { |
|||
t.Errorf("Expected %v, got %v", tc.expected, result) |
|||
} |
|||
}) |
|||
} |
|||
} |
|||
|
|||
// TestSSES3MetadataSerialization tests SSE-S3 metadata serialization and deserialization
|
|||
func TestSSES3MetadataSerialization(t *testing.T) { |
|||
// Initialize global key manager
|
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
defer func() { |
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
}() |
|||
|
|||
// Set up the key manager with a super key for testing
|
|||
keyManager := GetSSES3KeyManager() |
|||
keyManager.superKey = make([]byte, 32) |
|||
for i := range keyManager.superKey { |
|||
keyManager.superKey[i] = byte(i) |
|||
} |
|||
|
|||
// Generate SSE-S3 key
|
|||
sseS3Key, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key: %v", err) |
|||
} |
|||
|
|||
// Add IV to the key
|
|||
sseS3Key.IV = make([]byte, 16) |
|||
for i := range sseS3Key.IV { |
|||
sseS3Key.IV[i] = byte(i * 2) |
|||
} |
|||
|
|||
// Serialize metadata
|
|||
serialized, err := SerializeSSES3Metadata(sseS3Key) |
|||
if err != nil { |
|||
t.Fatalf("Failed to serialize SSE-S3 metadata: %v", err) |
|||
} |
|||
|
|||
if len(serialized) == 0 { |
|||
t.Error("Serialized metadata is empty") |
|||
} |
|||
|
|||
// Deserialize metadata
|
|||
deserializedKey, err := DeserializeSSES3Metadata(serialized, keyManager) |
|||
if err != nil { |
|||
t.Fatalf("Failed to deserialize SSE-S3 metadata: %v", err) |
|||
} |
|||
|
|||
// Verify key matches
|
|||
if !bytes.Equal(deserializedKey.Key, sseS3Key.Key) { |
|||
t.Error("Deserialized key doesn't match original key") |
|||
} |
|||
|
|||
// Verify IV matches
|
|||
if !bytes.Equal(deserializedKey.IV, sseS3Key.IV) { |
|||
t.Error("Deserialized IV doesn't match original IV") |
|||
} |
|||
|
|||
// Verify algorithm matches
|
|||
if deserializedKey.Algorithm != sseS3Key.Algorithm { |
|||
t.Errorf("Algorithm mismatch: expected %s, got %s", sseS3Key.Algorithm, deserializedKey.Algorithm) |
|||
} |
|||
|
|||
// Verify key ID matches
|
|||
if deserializedKey.KeyID != sseS3Key.KeyID { |
|||
t.Errorf("Key ID mismatch: expected %s, got %s", sseS3Key.KeyID, deserializedKey.KeyID) |
|||
} |
|||
} |
|||
|
|||
// TestDetectPrimarySSETypeS3 tests detection of SSE-S3 as primary encryption type
|
|||
func TestDetectPrimarySSETypeS3(t *testing.T) { |
|||
s3a := &S3ApiServer{} |
|||
|
|||
testCases := []struct { |
|||
name string |
|||
entry *filer_pb.Entry |
|||
expected string |
|||
}{ |
|||
{ |
|||
name: "Single SSE-S3 chunk", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{ |
|||
{ |
|||
FileId: "1,123", |
|||
Offset: 0, |
|||
Size: 1024, |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: []byte("metadata"), |
|||
}, |
|||
}, |
|||
}, |
|||
expected: s3_constants.SSETypeS3, |
|||
}, |
|||
{ |
|||
name: "Multiple SSE-S3 chunks", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{ |
|||
{ |
|||
FileId: "1,123", |
|||
Offset: 0, |
|||
Size: 1024, |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: []byte("metadata1"), |
|||
}, |
|||
{ |
|||
FileId: "2,456", |
|||
Offset: 1024, |
|||
Size: 1024, |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: []byte("metadata2"), |
|||
}, |
|||
}, |
|||
}, |
|||
expected: s3_constants.SSETypeS3, |
|||
}, |
|||
{ |
|||
name: "Mixed SSE-S3 and SSE-KMS chunks (SSE-S3 majority)", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{ |
|||
{ |
|||
FileId: "1,123", |
|||
Offset: 0, |
|||
Size: 1024, |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: []byte("metadata1"), |
|||
}, |
|||
{ |
|||
FileId: "2,456", |
|||
Offset: 1024, |
|||
Size: 1024, |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: []byte("metadata2"), |
|||
}, |
|||
{ |
|||
FileId: "3,789", |
|||
Offset: 2048, |
|||
Size: 1024, |
|||
SseType: filer_pb.SSEType_SSE_KMS, |
|||
SseMetadata: []byte("metadata3"), |
|||
}, |
|||
}, |
|||
}, |
|||
expected: s3_constants.SSETypeS3, |
|||
}, |
|||
{ |
|||
name: "No chunks, SSE-S3 metadata without KMS key ID", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{}, |
|||
}, |
|||
expected: s3_constants.SSETypeS3, |
|||
}, |
|||
{ |
|||
name: "No chunks, SSE-KMS metadata with KMS key ID", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
s3_constants.AmzServerSideEncryptionAwsKmsKeyId: []byte("test-key-id"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{}, |
|||
}, |
|||
expected: s3_constants.SSETypeKMS, |
|||
}, |
|||
{ |
|||
name: "SSE-C chunks", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryptionCustomerAlgorithm: []byte("AES256"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{ |
|||
{ |
|||
FileId: "1,123", |
|||
Offset: 0, |
|||
Size: 1024, |
|||
SseType: filer_pb.SSEType_SSE_C, |
|||
SseMetadata: []byte("metadata"), |
|||
}, |
|||
}, |
|||
}, |
|||
expected: s3_constants.SSETypeC, |
|||
}, |
|||
{ |
|||
name: "Unencrypted", |
|||
entry: &filer_pb.Entry{ |
|||
Extended: map[string][]byte{}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{ |
|||
{ |
|||
FileId: "1,123", |
|||
Offset: 0, |
|||
Size: 1024, |
|||
}, |
|||
}, |
|||
}, |
|||
expected: "None", |
|||
}, |
|||
} |
|||
|
|||
for _, tc := range testCases { |
|||
t.Run(tc.name, func(t *testing.T) { |
|||
result := s3a.detectPrimarySSEType(tc.entry) |
|||
if result != tc.expected { |
|||
t.Errorf("Expected %s, got %s", tc.expected, result) |
|||
} |
|||
}) |
|||
} |
|||
} |
|||
|
|||
// TestAddSSES3HeadersToResponse tests that SSE-S3 headers are added to responses
|
|||
func TestAddSSES3HeadersToResponse(t *testing.T) { |
|||
s3a := &S3ApiServer{} |
|||
|
|||
entry := &filer_pb.Entry{ |
|||
Extended: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
Attributes: &filer_pb.FuseAttributes{}, |
|||
Chunks: []*filer_pb.FileChunk{ |
|||
{ |
|||
FileId: "1,123", |
|||
Offset: 0, |
|||
Size: 1024, |
|||
SseType: filer_pb.SSEType_SSE_S3, |
|||
SseMetadata: []byte("metadata"), |
|||
}, |
|||
}, |
|||
} |
|||
|
|||
proxyResponse := &http.Response{ |
|||
Header: make(http.Header), |
|||
} |
|||
|
|||
s3a.addSSEHeadersToResponse(proxyResponse, entry) |
|||
|
|||
algorithm := proxyResponse.Header.Get(s3_constants.AmzServerSideEncryption) |
|||
if algorithm != "AES256" { |
|||
t.Errorf("Expected SSE algorithm AES256, got %s", algorithm) |
|||
} |
|||
|
|||
// Should NOT have SSE-C or SSE-KMS specific headers
|
|||
if proxyResponse.Header.Get(s3_constants.AmzServerSideEncryptionCustomerAlgorithm) != "" { |
|||
t.Error("Should not have SSE-C customer algorithm header") |
|||
} |
|||
|
|||
if proxyResponse.Header.Get(s3_constants.AmzServerSideEncryptionAwsKmsKeyId) != "" { |
|||
t.Error("Should not have SSE-KMS key ID header") |
|||
} |
|||
} |
|||
|
|||
// TestSSES3EncryptionWithBaseIV tests multipart encryption with base IV
|
|||
func TestSSES3EncryptionWithBaseIV(t *testing.T) { |
|||
// Generate SSE-S3 key
|
|||
sseS3Key, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key: %v", err) |
|||
} |
|||
|
|||
// Generate base IV
|
|||
baseIV := make([]byte, 16) |
|||
for i := range baseIV { |
|||
baseIV[i] = byte(i) |
|||
} |
|||
|
|||
// Test data for two parts
|
|||
testData1 := []byte("Part 1 of multipart upload test.") |
|||
testData2 := []byte("Part 2 of multipart upload test.") |
|||
|
|||
// Encrypt part 1 at offset 0
|
|||
dataReader1 := bytes.NewReader(testData1) |
|||
encryptedReader1, iv1, err := CreateSSES3EncryptedReaderWithBaseIV(dataReader1, sseS3Key, baseIV, 0) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create encrypted reader for part 1: %v", err) |
|||
} |
|||
|
|||
encryptedData1, err := io.ReadAll(encryptedReader1) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read encrypted data for part 1: %v", err) |
|||
} |
|||
|
|||
// Encrypt part 2 at offset (simulating second part)
|
|||
dataReader2 := bytes.NewReader(testData2) |
|||
offset2 := int64(len(testData1)) |
|||
encryptedReader2, iv2, err := CreateSSES3EncryptedReaderWithBaseIV(dataReader2, sseS3Key, baseIV, offset2) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create encrypted reader for part 2: %v", err) |
|||
} |
|||
|
|||
encryptedData2, err := io.ReadAll(encryptedReader2) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read encrypted data for part 2: %v", err) |
|||
} |
|||
|
|||
// IVs should be different (offset-based)
|
|||
if bytes.Equal(iv1, iv2) { |
|||
t.Error("IVs should be different for different offsets") |
|||
} |
|||
|
|||
// Decrypt part 1
|
|||
decryptedReader1, err := CreateSSES3DecryptedReader(bytes.NewReader(encryptedData1), sseS3Key, iv1) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create decrypted reader for part 1: %v", err) |
|||
} |
|||
|
|||
decryptedData1, err := io.ReadAll(decryptedReader1) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read decrypted data for part 1: %v", err) |
|||
} |
|||
|
|||
// Decrypt part 2
|
|||
decryptedReader2, err := CreateSSES3DecryptedReader(bytes.NewReader(encryptedData2), sseS3Key, iv2) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create decrypted reader for part 2: %v", err) |
|||
} |
|||
|
|||
decryptedData2, err := io.ReadAll(decryptedReader2) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read decrypted data for part 2: %v", err) |
|||
} |
|||
|
|||
// Verify decrypted data matches original
|
|||
if !bytes.Equal(decryptedData1, testData1) { |
|||
t.Errorf("Decrypted part 1 doesn't match original.\nOriginal: %s\nDecrypted: %s", testData1, decryptedData1) |
|||
} |
|||
|
|||
if !bytes.Equal(decryptedData2, testData2) { |
|||
t.Errorf("Decrypted part 2 doesn't match original.\nOriginal: %s\nDecrypted: %s", testData2, decryptedData2) |
|||
} |
|||
} |
|||
|
|||
// TestSSES3WrongKeyDecryption tests that wrong key fails decryption
|
|||
func TestSSES3WrongKeyDecryption(t *testing.T) { |
|||
// Generate two different keys
|
|||
sseS3Key1, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key 1: %v", err) |
|||
} |
|||
|
|||
sseS3Key2, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key 2: %v", err) |
|||
} |
|||
|
|||
// Test data
|
|||
testData := []byte("Secret data encrypted with key 1") |
|||
|
|||
// Encrypt with key 1
|
|||
dataReader := bytes.NewReader(testData) |
|||
encryptedReader, iv, err := CreateSSES3EncryptedReader(dataReader, sseS3Key1) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create encrypted reader: %v", err) |
|||
} |
|||
|
|||
encryptedData, err := io.ReadAll(encryptedReader) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read encrypted data: %v", err) |
|||
} |
|||
|
|||
// Try to decrypt with key 2 (wrong key)
|
|||
decryptedReader, err := CreateSSES3DecryptedReader(bytes.NewReader(encryptedData), sseS3Key2, iv) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create decrypted reader: %v", err) |
|||
} |
|||
|
|||
decryptedData, err := io.ReadAll(decryptedReader) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read decrypted data: %v", err) |
|||
} |
|||
|
|||
// Decrypted data should NOT match original (wrong key produces garbage)
|
|||
if bytes.Equal(decryptedData, testData) { |
|||
t.Error("Decryption with wrong key should not produce correct plaintext") |
|||
} |
|||
} |
|||
|
|||
// TestSSES3KeyGeneration tests SSE-S3 key generation
|
|||
func TestSSES3KeyGeneration(t *testing.T) { |
|||
// Generate multiple keys
|
|||
keys := make([]*SSES3Key, 10) |
|||
for i := range keys { |
|||
key, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key %d: %v", i, err) |
|||
} |
|||
keys[i] = key |
|||
|
|||
// Verify key properties
|
|||
if len(key.Key) != SSES3KeySize { |
|||
t.Errorf("Key %d has wrong size: expected %d, got %d", i, SSES3KeySize, len(key.Key)) |
|||
} |
|||
|
|||
if key.Algorithm != SSES3Algorithm { |
|||
t.Errorf("Key %d has wrong algorithm: expected %s, got %s", i, SSES3Algorithm, key.Algorithm) |
|||
} |
|||
|
|||
if key.KeyID == "" { |
|||
t.Errorf("Key %d has empty key ID", i) |
|||
} |
|||
} |
|||
|
|||
// Verify keys are unique
|
|||
for i := 0; i < len(keys); i++ { |
|||
for j := i + 1; j < len(keys); j++ { |
|||
if bytes.Equal(keys[i].Key, keys[j].Key) { |
|||
t.Errorf("Keys %d and %d are identical (should be unique)", i, j) |
|||
} |
|||
if keys[i].KeyID == keys[j].KeyID { |
|||
t.Errorf("Key IDs %d and %d are identical (should be unique)", i, j) |
|||
} |
|||
} |
|||
} |
|||
} |
|||
|
|||
// TestSSES3VariousSizes tests SSE-S3 encryption/decryption with various data sizes
|
|||
func TestSSES3VariousSizes(t *testing.T) { |
|||
sizes := []int{1, 15, 16, 17, 100, 1024, 4096, 1048576} |
|||
|
|||
for _, size := range sizes { |
|||
t.Run(fmt.Sprintf("size_%d", size), func(t *testing.T) { |
|||
// Generate test data
|
|||
testData := make([]byte, size) |
|||
for i := range testData { |
|||
testData[i] = byte(i % 256) |
|||
} |
|||
|
|||
// Generate key
|
|||
sseS3Key, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key: %v", err) |
|||
} |
|||
|
|||
// Encrypt
|
|||
dataReader := bytes.NewReader(testData) |
|||
encryptedReader, iv, err := CreateSSES3EncryptedReader(dataReader, sseS3Key) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create encrypted reader: %v", err) |
|||
} |
|||
|
|||
encryptedData, err := io.ReadAll(encryptedReader) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read encrypted data: %v", err) |
|||
} |
|||
|
|||
// Verify encrypted size matches original
|
|||
if len(encryptedData) != size { |
|||
t.Errorf("Encrypted size mismatch: expected %d, got %d", size, len(encryptedData)) |
|||
} |
|||
|
|||
// Decrypt
|
|||
decryptedReader, err := CreateSSES3DecryptedReader(bytes.NewReader(encryptedData), sseS3Key, iv) |
|||
if err != nil { |
|||
t.Fatalf("Failed to create decrypted reader: %v", err) |
|||
} |
|||
|
|||
decryptedData, err := io.ReadAll(decryptedReader) |
|||
if err != nil { |
|||
t.Fatalf("Failed to read decrypted data: %v", err) |
|||
} |
|||
|
|||
// Verify
|
|||
if !bytes.Equal(decryptedData, testData) { |
|||
t.Errorf("Decrypted data doesn't match original for size %d", size) |
|||
} |
|||
}) |
|||
} |
|||
} |
|||
|
|||
// TestSSES3ResponseHeaders tests that SSE-S3 response headers are set correctly
|
|||
func TestSSES3ResponseHeaders(t *testing.T) { |
|||
w := httptest.NewRecorder() |
|||
|
|||
// Simulate setting SSE-S3 response headers
|
|||
w.Header().Set(s3_constants.AmzServerSideEncryption, SSES3Algorithm) |
|||
|
|||
// Verify headers
|
|||
algorithm := w.Header().Get(s3_constants.AmzServerSideEncryption) |
|||
if algorithm != "AES256" { |
|||
t.Errorf("Expected algorithm AES256, got %s", algorithm) |
|||
} |
|||
|
|||
// Should NOT have customer key headers
|
|||
if w.Header().Get(s3_constants.AmzServerSideEncryptionCustomerAlgorithm) != "" { |
|||
t.Error("Should not have SSE-C customer algorithm header") |
|||
} |
|||
|
|||
if w.Header().Get(s3_constants.AmzServerSideEncryptionCustomerKeyMD5) != "" { |
|||
t.Error("Should not have SSE-C customer key MD5 header") |
|||
} |
|||
|
|||
// Should NOT have KMS key ID
|
|||
if w.Header().Get(s3_constants.AmzServerSideEncryptionAwsKmsKeyId) != "" { |
|||
t.Error("Should not have SSE-KMS key ID header") |
|||
} |
|||
} |
|||
|
|||
// TestSSES3IsEncryptedInternal tests detection of SSE-S3 encryption from metadata
|
|||
func TestSSES3IsEncryptedInternal(t *testing.T) { |
|||
testCases := []struct { |
|||
name string |
|||
metadata map[string][]byte |
|||
expected bool |
|||
}{ |
|||
{ |
|||
name: "Empty metadata", |
|||
metadata: map[string][]byte{}, |
|||
expected: false, |
|||
}, |
|||
{ |
|||
name: "Valid SSE-S3 metadata", |
|||
metadata: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("AES256"), |
|||
}, |
|||
expected: true, |
|||
}, |
|||
{ |
|||
name: "SSE-KMS metadata", |
|||
metadata: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryption: []byte("aws:kms"), |
|||
}, |
|||
expected: false, |
|||
}, |
|||
{ |
|||
name: "SSE-C metadata", |
|||
metadata: map[string][]byte{ |
|||
s3_constants.AmzServerSideEncryptionCustomerAlgorithm: []byte("AES256"), |
|||
}, |
|||
expected: false, |
|||
}, |
|||
} |
|||
|
|||
for _, tc := range testCases { |
|||
t.Run(tc.name, func(t *testing.T) { |
|||
result := IsSSES3EncryptedInternal(tc.metadata) |
|||
if result != tc.expected { |
|||
t.Errorf("Expected %v, got %v", tc.expected, result) |
|||
} |
|||
}) |
|||
} |
|||
} |
|||
|
|||
// TestSSES3InvalidMetadataDeserialization tests error handling for invalid metadata
|
|||
func TestSSES3InvalidMetadataDeserialization(t *testing.T) { |
|||
keyManager := NewSSES3KeyManager() |
|||
keyManager.superKey = make([]byte, 32) |
|||
|
|||
testCases := []struct { |
|||
name string |
|||
metadata []byte |
|||
shouldError bool |
|||
}{ |
|||
{ |
|||
name: "Empty metadata", |
|||
metadata: []byte{}, |
|||
shouldError: true, |
|||
}, |
|||
{ |
|||
name: "Invalid JSON", |
|||
metadata: []byte("not valid json"), |
|||
shouldError: true, |
|||
}, |
|||
{ |
|||
name: "Missing keyId", |
|||
metadata: []byte(`{"algorithm":"AES256"}`), |
|||
shouldError: true, |
|||
}, |
|||
{ |
|||
name: "Invalid base64 encrypted DEK", |
|||
metadata: []byte(`{"keyId":"test","algorithm":"AES256","encryptedDEK":"not-valid-base64!","nonce":"dGVzdA=="}`), |
|||
shouldError: true, |
|||
}, |
|||
} |
|||
|
|||
for _, tc := range testCases { |
|||
t.Run(tc.name, func(t *testing.T) { |
|||
_, err := DeserializeSSES3Metadata(tc.metadata, keyManager) |
|||
if tc.shouldError && err == nil { |
|||
t.Error("Expected error but got none") |
|||
} |
|||
if !tc.shouldError && err != nil { |
|||
t.Errorf("Unexpected error: %v", err) |
|||
} |
|||
}) |
|||
} |
|||
} |
|||
|
|||
// TestGetSSES3Headers tests SSE-S3 header generation
|
|||
func TestGetSSES3Headers(t *testing.T) { |
|||
headers := GetSSES3Headers() |
|||
|
|||
if len(headers) == 0 { |
|||
t.Error("Expected headers to be non-empty") |
|||
} |
|||
|
|||
algorithm, exists := headers[s3_constants.AmzServerSideEncryption] |
|||
if !exists { |
|||
t.Error("Expected AmzServerSideEncryption header to exist") |
|||
} |
|||
|
|||
if algorithm != "AES256" { |
|||
t.Errorf("Expected algorithm AES256, got %s", algorithm) |
|||
} |
|||
} |
|||
|
|||
// TestProcessSSES3Request tests processing of SSE-S3 requests
|
|||
func TestProcessSSES3Request(t *testing.T) { |
|||
// Initialize global key manager
|
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
defer func() { |
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
}() |
|||
|
|||
// Set up the key manager with a super key for testing
|
|||
keyManager := GetSSES3KeyManager() |
|||
keyManager.superKey = make([]byte, 32) |
|||
for i := range keyManager.superKey { |
|||
keyManager.superKey[i] = byte(i) |
|||
} |
|||
|
|||
// Create SSE-S3 request
|
|||
req := httptest.NewRequest("PUT", "/bucket/object", nil) |
|||
req.Header.Set(s3_constants.AmzServerSideEncryption, "AES256") |
|||
|
|||
// Process request
|
|||
metadata, err := ProcessSSES3Request(req) |
|||
if err != nil { |
|||
t.Fatalf("Failed to process SSE-S3 request: %v", err) |
|||
} |
|||
|
|||
if metadata == nil { |
|||
t.Fatal("Expected metadata to be non-nil") |
|||
} |
|||
|
|||
// Verify metadata contains SSE algorithm
|
|||
if sseAlgo, exists := metadata[s3_constants.AmzServerSideEncryption]; !exists { |
|||
t.Error("Expected SSE algorithm in metadata") |
|||
} else if string(sseAlgo) != "AES256" { |
|||
t.Errorf("Expected AES256, got %s", string(sseAlgo)) |
|||
} |
|||
|
|||
// Verify metadata contains key data
|
|||
if _, exists := metadata[s3_constants.SeaweedFSSSES3Key]; !exists { |
|||
t.Error("Expected SSE-S3 key data in metadata") |
|||
} |
|||
} |
|||
|
|||
// TestGetSSES3KeyFromMetadata tests extraction of SSE-S3 key from metadata
|
|||
func TestGetSSES3KeyFromMetadata(t *testing.T) { |
|||
// Initialize global key manager
|
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
defer func() { |
|||
globalSSES3KeyManager = NewSSES3KeyManager() |
|||
}() |
|||
|
|||
// Set up the key manager with a super key for testing
|
|||
keyManager := GetSSES3KeyManager() |
|||
keyManager.superKey = make([]byte, 32) |
|||
for i := range keyManager.superKey { |
|||
keyManager.superKey[i] = byte(i) |
|||
} |
|||
|
|||
// Generate and serialize key
|
|||
sseS3Key, err := GenerateSSES3Key() |
|||
if err != nil { |
|||
t.Fatalf("Failed to generate SSE-S3 key: %v", err) |
|||
} |
|||
|
|||
sseS3Key.IV = make([]byte, 16) |
|||
for i := range sseS3Key.IV { |
|||
sseS3Key.IV[i] = byte(i) |
|||
} |
|||
|
|||
serialized, err := SerializeSSES3Metadata(sseS3Key) |
|||
if err != nil { |
|||
t.Fatalf("Failed to serialize SSE-S3 metadata: %v", err) |
|||
} |
|||
|
|||
metadata := map[string][]byte{ |
|||
s3_constants.SeaweedFSSSES3Key: serialized, |
|||
} |
|||
|
|||
// Extract key
|
|||
extractedKey, err := GetSSES3KeyFromMetadata(metadata, keyManager) |
|||
if err != nil { |
|||
t.Fatalf("Failed to get SSE-S3 key from metadata: %v", err) |
|||
} |
|||
|
|||
// Verify key matches
|
|||
if !bytes.Equal(extractedKey.Key, sseS3Key.Key) { |
|||
t.Error("Extracted key doesn't match original key") |
|||
} |
|||
|
|||
if !bytes.Equal(extractedKey.IV, sseS3Key.IV) { |
|||
t.Error("Extracted IV doesn't match original IV") |
|||
} |
|||
} |
|||
|
|||
// TestSSES3EnvelopeEncryption tests that envelope encryption works correctly
|
|||
func TestSSES3EnvelopeEncryption(t *testing.T) { |
|||
// Initialize key manager with a super key
|
|||
keyManager := NewSSES3KeyManager() |
|||
keyManager.superKey = make([]byte, 32) |
|||
for i := range keyManager.superKey { |
|||
keyManager.superKey[i] = byte(i + 100) |
|||
} |
|||
|
|||
// Generate a DEK
|
|||
dek := make([]byte, 32) |
|||
for i := range dek { |
|||
dek[i] = byte(i) |
|||
} |
|||
|
|||
// Encrypt DEK with super key
|
|||
encryptedDEK, nonce, err := keyManager.encryptKeyWithSuperKey(dek) |
|||
if err != nil { |
|||
t.Fatalf("Failed to encrypt DEK: %v", err) |
|||
} |
|||
|
|||
if len(encryptedDEK) == 0 { |
|||
t.Error("Encrypted DEK is empty") |
|||
} |
|||
|
|||
if len(nonce) == 0 { |
|||
t.Error("Nonce is empty") |
|||
} |
|||
|
|||
// Decrypt DEK with super key
|
|||
decryptedDEK, err := keyManager.decryptKeyWithSuperKey(encryptedDEK, nonce) |
|||
if err != nil { |
|||
t.Fatalf("Failed to decrypt DEK: %v", err) |
|||
} |
|||
|
|||
// Verify DEK matches
|
|||
if !bytes.Equal(decryptedDEK, dek) { |
|||
t.Error("Decrypted DEK doesn't match original DEK") |
|||
} |
|||
} |
|||
|
|||
// TestValidateSSES3Key tests SSE-S3 key validation
|
|||
func TestValidateSSES3Key(t *testing.T) { |
|||
testCases := []struct { |
|||
name string |
|||
key *SSES3Key |
|||
shouldError bool |
|||
errorMsg string |
|||
}{ |
|||
{ |
|||
name: "Nil key", |
|||
key: nil, |
|||
shouldError: true, |
|||
errorMsg: "SSE-S3 key cannot be nil", |
|||
}, |
|||
{ |
|||
name: "Valid key", |
|||
key: &SSES3Key{ |
|||
Key: make([]byte, 32), |
|||
KeyID: "test-key", |
|||
Algorithm: "AES256", |
|||
}, |
|||
shouldError: false, |
|||
}, |
|||
{ |
|||
name: "Valid key with IV", |
|||
key: &SSES3Key{ |
|||
Key: make([]byte, 32), |
|||
KeyID: "test-key", |
|||
Algorithm: "AES256", |
|||
IV: make([]byte, 16), |
|||
}, |
|||
shouldError: false, |
|||
}, |
|||
{ |
|||
name: "Invalid key size (too small)", |
|||
key: &SSES3Key{ |
|||
Key: make([]byte, 16), |
|||
KeyID: "test-key", |
|||
Algorithm: "AES256", |
|||
}, |
|||
shouldError: true, |
|||
errorMsg: "invalid SSE-S3 key size", |
|||
}, |
|||
{ |
|||
name: "Invalid key size (too large)", |
|||
key: &SSES3Key{ |
|||
Key: make([]byte, 64), |
|||
KeyID: "test-key", |
|||
Algorithm: "AES256", |
|||
}, |
|||
shouldError: true, |
|||
errorMsg: "invalid SSE-S3 key size", |
|||
}, |
|||
{ |
|||
name: "Nil key bytes", |
|||
key: &SSES3Key{ |
|||
Key: nil, |
|||
KeyID: "test-key", |
|||
Algorithm: "AES256", |
|||
}, |
|||
shouldError: true, |
|||
errorMsg: "SSE-S3 key bytes cannot be nil", |
|||
}, |
|||
{ |
|||
name: "Empty key ID", |
|||
key: &SSES3Key{ |
|||
Key: make([]byte, 32), |
|||
KeyID: "", |
|||
Algorithm: "AES256", |
|||
}, |
|||
shouldError: true, |
|||
errorMsg: "SSE-S3 key ID cannot be empty", |
|||
}, |
|||
{ |
|||
name: "Invalid algorithm", |
|||
key: &SSES3Key{ |
|||
Key: make([]byte, 32), |
|||
KeyID: "test-key", |
|||
Algorithm: "INVALID", |
|||
}, |
|||
shouldError: true, |
|||
errorMsg: "invalid SSE-S3 algorithm", |
|||
}, |
|||
{ |
|||
name: "Invalid IV length", |
|||
key: &SSES3Key{ |
|||
Key: make([]byte, 32), |
|||
KeyID: "test-key", |
|||
Algorithm: "AES256", |
|||
IV: make([]byte, 8), // Wrong size
|
|||
}, |
|||
shouldError: true, |
|||
errorMsg: "invalid SSE-S3 IV length", |
|||
}, |
|||
{ |
|||
name: "Empty IV is allowed (set during encryption)", |
|||
key: &SSES3Key{ |
|||
Key: make([]byte, 32), |
|||
KeyID: "test-key", |
|||
Algorithm: "AES256", |
|||
IV: []byte{}, // Empty is OK
|
|||
}, |
|||
shouldError: false, |
|||
}, |
|||
} |
|||
|
|||
for _, tc := range testCases { |
|||
t.Run(tc.name, func(t *testing.T) { |
|||
err := ValidateSSES3Key(tc.key) |
|||
if tc.shouldError { |
|||
if err == nil { |
|||
t.Error("Expected error but got none") |
|||
} else if tc.errorMsg != "" && !strings.Contains(err.Error(), tc.errorMsg) { |
|||
t.Errorf("Expected error containing %q, got: %v", tc.errorMsg, err) |
|||
} |
|||
} else { |
|||
if err != nil { |
|||
t.Errorf("Unexpected error: %v", err) |
|||
} |
|||
} |
|||
}) |
|||
} |
|||
} |
|||
Write
Preview
Loading…
Cancel
Save
Reference in new issue