Browse Source

cleanup(iam): remove temporary debug logging from STS and S3 API

allow-no-role-arn
Chris Lu 3 weeks ago
parent
commit
006a5b5546
  1. 4
      weed/s3api/s3_iam_middleware.go
  2. 3
      weed/s3api/s3api_server.go
  3. 2
      weed/s3api/s3api_sts.go

4
weed/s3api/s3_iam_middleware.go

@ -233,10 +233,6 @@ func (s3iam *S3IAMIntegration) ValidateSessionToken(ctx context.Context, token s
// AuthorizeAction authorizes actions using our policy engine // AuthorizeAction authorizes actions using our policy engine
func (s3iam *S3IAMIntegration) AuthorizeAction(ctx context.Context, identity *IAMIdentity, action Action, bucket string, objectKey string, r *http.Request) s3err.ErrorCode { func (s3iam *S3IAMIntegration) AuthorizeAction(ctx context.Context, identity *IAMIdentity, action Action, bucket string, objectKey string, r *http.Request) s3err.ErrorCode {
fmt.Printf("DEBUG: AuthorizeAction called: Identity=%s Action=%s Bucket=%s Enabled=%v\n", identity.Name, action, bucket, s3iam.enabled)
if identity.Claims != nil {
fmt.Printf("DEBUG: AuthorizeAction Identity.Claims=%v\n", identity.Claims)
}
if !s3iam.enabled { if !s3iam.enabled {
return s3err.ErrNone // Fallback to existing authorization return s3err.ErrNone // Fallback to existing authorization
} }

3
weed/s3api/s3api_server.go

@ -852,11 +852,8 @@ func loadIAMManagerFromConfig(configPath string, filerAddressProvider func() str
if err := json.Unmarshal(configData, &configRoot); err != nil { if err := json.Unmarshal(configData, &configRoot); err != nil {
return nil, fmt.Errorf("failed to parse config: %w", err) return nil, fmt.Errorf("failed to parse config: %w", err)
} }
glog.V(0).Infof("DEBUG: Loaded IAM Config. Policy=%v. Raw JSON len=%d", configRoot.Policy, len(configData))
if configRoot.Policy != nil { if configRoot.Policy != nil {
glog.V(0).Infof("DEBUG: Policy Config: DefaultEffect='%s'", configRoot.Policy.DefaultEffect)
} else { } else {
glog.V(0).Infof("DEBUG: Policy Config is NIL")
} }
// Ensure a valid policy engine config exists // Ensure a valid policy engine config exists

2
weed/s3api/s3api_sts.go

@ -186,8 +186,6 @@ func (h *STSHandlers) handleAssumeRoleWithWebIdentity(w http.ResponseWriter, r *
Policy: sessionPolicyPtr, Policy: sessionPolicyPtr,
} }
glog.V(0).Infof("DEBUG: AssumeRoleWithWebIdentity: RoleArn=%s SessionPolicyLen=%d", roleArn, len(sessionPolicyJSON))
// Call STS service // Call STS service
response, err := h.stsService.AssumeRoleWithWebIdentity(ctx, request) response, err := h.stsService.AssumeRoleWithWebIdentity(ctx, request)
if err != nil { if err != nil {

Loading…
Cancel
Save