You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

527 lines
15 KiB

3 years ago
6 years ago
7 years ago
7 years ago
7 years ago
3 years ago
3 years ago
3 years ago
3 years ago
3 years ago
4 years ago
4 years ago
3 years ago
3 years ago
3 years ago
3 years ago
3 years ago
4 years ago
3 years ago
3 years ago
3 years ago
3 years ago
3 years ago
3 years ago
3 years ago
FEATURE: add JWT to HTTP endpoints of Filer and use them in S3 Client - one JWT for reading and one for writing, analogous to how the JWT between Master and Volume Server works - I did not implement IP `whiteList` parameter on the filer Additionally, because http_util.DownloadFile now sets the JWT, the `download` command should now work when `jwt.signing.read` is configured. By looking at the code, I think this case did not work before. ## Docs to be adjusted after a release Page `Amazon-S3-API`: ``` # Authentication with Filer You can use mTLS for the gRPC connection between S3-API-Proxy and the filer, as explained in [Security-Configuration](Security-Configuration) - controlled by the `grpc.*` configuration in `security.toml`. Starting with version XX, it is also possible to authenticate the HTTP operations between the S3-API-Proxy and the Filer (especially uploading new files). This is configured by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. With both configurations (gRPC and JWT), it is possible to have Filer and S3 communicate in fully authenticated fashion; so Filer will reject any unauthenticated communication. ``` Page `Security Overview`: ``` The following items are not covered, yet: - master server http REST services Starting with version XX, the Filer HTTP REST services can be secured with a JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. ... Before version XX: "weed filer -disableHttp", disable http operations, only gRPC operations are allowed. This works with "weed mount" by FUSE. It does **not work** with the [S3 Gateway](Amazon S3 API), as this does HTTP calls to the Filer. Starting with version XX: secured by JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. **This now works with the [S3 Gateway](Amazon S3 API).** ... # Securing Filer HTTP with JWT To enable JWT-based access control for the Filer, 1. generate `security.toml` file by `weed scaffold -config=security` 2. set `filer_jwt.signing.key` to a secret string - and optionally filer_jwt.signing.read.key` as well to a secret string 3. copy the same `security.toml` file to the filers and all S3 proxies. If `filer_jwt.signing.key` is configured: When sending upload/update/delete HTTP operations to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.key`. If `filer_jwt.signing.read.key` is configured: When sending GET or HEAD requests to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.read.key`. The S3 API Gateway reads the above JWT keys and sends authenticated HTTP requests to the filer. ``` Page `Security Configuration`: ``` (update scaffold file) ... [filer_jwt.signing] key = "blahblahblahblah" [filer_jwt.signing.read] key = "blahblahblahblah" ``` Resolves: #158
3 years ago
3 years ago
FEATURE: add JWT to HTTP endpoints of Filer and use them in S3 Client - one JWT for reading and one for writing, analogous to how the JWT between Master and Volume Server works - I did not implement IP `whiteList` parameter on the filer Additionally, because http_util.DownloadFile now sets the JWT, the `download` command should now work when `jwt.signing.read` is configured. By looking at the code, I think this case did not work before. ## Docs to be adjusted after a release Page `Amazon-S3-API`: ``` # Authentication with Filer You can use mTLS for the gRPC connection between S3-API-Proxy and the filer, as explained in [Security-Configuration](Security-Configuration) - controlled by the `grpc.*` configuration in `security.toml`. Starting with version XX, it is also possible to authenticate the HTTP operations between the S3-API-Proxy and the Filer (especially uploading new files). This is configured by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. With both configurations (gRPC and JWT), it is possible to have Filer and S3 communicate in fully authenticated fashion; so Filer will reject any unauthenticated communication. ``` Page `Security Overview`: ``` The following items are not covered, yet: - master server http REST services Starting with version XX, the Filer HTTP REST services can be secured with a JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. ... Before version XX: "weed filer -disableHttp", disable http operations, only gRPC operations are allowed. This works with "weed mount" by FUSE. It does **not work** with the [S3 Gateway](Amazon S3 API), as this does HTTP calls to the Filer. Starting with version XX: secured by JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. **This now works with the [S3 Gateway](Amazon S3 API).** ... # Securing Filer HTTP with JWT To enable JWT-based access control for the Filer, 1. generate `security.toml` file by `weed scaffold -config=security` 2. set `filer_jwt.signing.key` to a secret string - and optionally filer_jwt.signing.read.key` as well to a secret string 3. copy the same `security.toml` file to the filers and all S3 proxies. If `filer_jwt.signing.key` is configured: When sending upload/update/delete HTTP operations to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.key`. If `filer_jwt.signing.read.key` is configured: When sending GET or HEAD requests to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.read.key`. The S3 API Gateway reads the above JWT keys and sends authenticated HTTP requests to the filer. ``` Page `Security Configuration`: ``` (update scaffold file) ... [filer_jwt.signing] key = "blahblahblahblah" [filer_jwt.signing.read] key = "blahblahblahblah" ``` Resolves: #158
3 years ago
3 years ago
FEATURE: add JWT to HTTP endpoints of Filer and use them in S3 Client - one JWT for reading and one for writing, analogous to how the JWT between Master and Volume Server works - I did not implement IP `whiteList` parameter on the filer Additionally, because http_util.DownloadFile now sets the JWT, the `download` command should now work when `jwt.signing.read` is configured. By looking at the code, I think this case did not work before. ## Docs to be adjusted after a release Page `Amazon-S3-API`: ``` # Authentication with Filer You can use mTLS for the gRPC connection between S3-API-Proxy and the filer, as explained in [Security-Configuration](Security-Configuration) - controlled by the `grpc.*` configuration in `security.toml`. Starting with version XX, it is also possible to authenticate the HTTP operations between the S3-API-Proxy and the Filer (especially uploading new files). This is configured by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. With both configurations (gRPC and JWT), it is possible to have Filer and S3 communicate in fully authenticated fashion; so Filer will reject any unauthenticated communication. ``` Page `Security Overview`: ``` The following items are not covered, yet: - master server http REST services Starting with version XX, the Filer HTTP REST services can be secured with a JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. ... Before version XX: "weed filer -disableHttp", disable http operations, only gRPC operations are allowed. This works with "weed mount" by FUSE. It does **not work** with the [S3 Gateway](Amazon S3 API), as this does HTTP calls to the Filer. Starting with version XX: secured by JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. **This now works with the [S3 Gateway](Amazon S3 API).** ... # Securing Filer HTTP with JWT To enable JWT-based access control for the Filer, 1. generate `security.toml` file by `weed scaffold -config=security` 2. set `filer_jwt.signing.key` to a secret string - and optionally filer_jwt.signing.read.key` as well to a secret string 3. copy the same `security.toml` file to the filers and all S3 proxies. If `filer_jwt.signing.key` is configured: When sending upload/update/delete HTTP operations to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.key`. If `filer_jwt.signing.read.key` is configured: When sending GET or HEAD requests to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.read.key`. The S3 API Gateway reads the above JWT keys and sends authenticated HTTP requests to the filer. ``` Page `Security Configuration`: ``` (update scaffold file) ... [filer_jwt.signing] key = "blahblahblahblah" [filer_jwt.signing.read] key = "blahblahblahblah" ``` Resolves: #158
3 years ago
4 years ago
3 years ago
3 years ago
3 years ago
FEATURE: add JWT to HTTP endpoints of Filer and use them in S3 Client - one JWT for reading and one for writing, analogous to how the JWT between Master and Volume Server works - I did not implement IP `whiteList` parameter on the filer Additionally, because http_util.DownloadFile now sets the JWT, the `download` command should now work when `jwt.signing.read` is configured. By looking at the code, I think this case did not work before. ## Docs to be adjusted after a release Page `Amazon-S3-API`: ``` # Authentication with Filer You can use mTLS for the gRPC connection between S3-API-Proxy and the filer, as explained in [Security-Configuration](Security-Configuration) - controlled by the `grpc.*` configuration in `security.toml`. Starting with version XX, it is also possible to authenticate the HTTP operations between the S3-API-Proxy and the Filer (especially uploading new files). This is configured by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. With both configurations (gRPC and JWT), it is possible to have Filer and S3 communicate in fully authenticated fashion; so Filer will reject any unauthenticated communication. ``` Page `Security Overview`: ``` The following items are not covered, yet: - master server http REST services Starting with version XX, the Filer HTTP REST services can be secured with a JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. ... Before version XX: "weed filer -disableHttp", disable http operations, only gRPC operations are allowed. This works with "weed mount" by FUSE. It does **not work** with the [S3 Gateway](Amazon S3 API), as this does HTTP calls to the Filer. Starting with version XX: secured by JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. **This now works with the [S3 Gateway](Amazon S3 API).** ... # Securing Filer HTTP with JWT To enable JWT-based access control for the Filer, 1. generate `security.toml` file by `weed scaffold -config=security` 2. set `filer_jwt.signing.key` to a secret string - and optionally filer_jwt.signing.read.key` as well to a secret string 3. copy the same `security.toml` file to the filers and all S3 proxies. If `filer_jwt.signing.key` is configured: When sending upload/update/delete HTTP operations to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.key`. If `filer_jwt.signing.read.key` is configured: When sending GET or HEAD requests to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.read.key`. The S3 API Gateway reads the above JWT keys and sends authenticated HTTP requests to the filer. ``` Page `Security Configuration`: ``` (update scaffold file) ... [filer_jwt.signing] key = "blahblahblahblah" [filer_jwt.signing.read] key = "blahblahblahblah" ``` Resolves: #158
3 years ago
3 years ago
3 years ago
4 years ago
3 years ago
5 years ago
4 years ago
4 years ago
4 years ago
4 years ago
4 years ago
4 years ago
FEATURE: add JWT to HTTP endpoints of Filer and use them in S3 Client - one JWT for reading and one for writing, analogous to how the JWT between Master and Volume Server works - I did not implement IP `whiteList` parameter on the filer Additionally, because http_util.DownloadFile now sets the JWT, the `download` command should now work when `jwt.signing.read` is configured. By looking at the code, I think this case did not work before. ## Docs to be adjusted after a release Page `Amazon-S3-API`: ``` # Authentication with Filer You can use mTLS for the gRPC connection between S3-API-Proxy and the filer, as explained in [Security-Configuration](Security-Configuration) - controlled by the `grpc.*` configuration in `security.toml`. Starting with version XX, it is also possible to authenticate the HTTP operations between the S3-API-Proxy and the Filer (especially uploading new files). This is configured by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. With both configurations (gRPC and JWT), it is possible to have Filer and S3 communicate in fully authenticated fashion; so Filer will reject any unauthenticated communication. ``` Page `Security Overview`: ``` The following items are not covered, yet: - master server http REST services Starting with version XX, the Filer HTTP REST services can be secured with a JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. ... Before version XX: "weed filer -disableHttp", disable http operations, only gRPC operations are allowed. This works with "weed mount" by FUSE. It does **not work** with the [S3 Gateway](Amazon S3 API), as this does HTTP calls to the Filer. Starting with version XX: secured by JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. **This now works with the [S3 Gateway](Amazon S3 API).** ... # Securing Filer HTTP with JWT To enable JWT-based access control for the Filer, 1. generate `security.toml` file by `weed scaffold -config=security` 2. set `filer_jwt.signing.key` to a secret string - and optionally filer_jwt.signing.read.key` as well to a secret string 3. copy the same `security.toml` file to the filers and all S3 proxies. If `filer_jwt.signing.key` is configured: When sending upload/update/delete HTTP operations to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.key`. If `filer_jwt.signing.read.key` is configured: When sending GET or HEAD requests to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.read.key`. The S3 API Gateway reads the above JWT keys and sends authenticated HTTP requests to the filer. ``` Page `Security Configuration`: ``` (update scaffold file) ... [filer_jwt.signing] key = "blahblahblahblah" [filer_jwt.signing.read] key = "blahblahblahblah" ``` Resolves: #158
3 years ago
FEATURE: add JWT to HTTP endpoints of Filer and use them in S3 Client - one JWT for reading and one for writing, analogous to how the JWT between Master and Volume Server works - I did not implement IP `whiteList` parameter on the filer Additionally, because http_util.DownloadFile now sets the JWT, the `download` command should now work when `jwt.signing.read` is configured. By looking at the code, I think this case did not work before. ## Docs to be adjusted after a release Page `Amazon-S3-API`: ``` # Authentication with Filer You can use mTLS for the gRPC connection between S3-API-Proxy and the filer, as explained in [Security-Configuration](Security-Configuration) - controlled by the `grpc.*` configuration in `security.toml`. Starting with version XX, it is also possible to authenticate the HTTP operations between the S3-API-Proxy and the Filer (especially uploading new files). This is configured by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. With both configurations (gRPC and JWT), it is possible to have Filer and S3 communicate in fully authenticated fashion; so Filer will reject any unauthenticated communication. ``` Page `Security Overview`: ``` The following items are not covered, yet: - master server http REST services Starting with version XX, the Filer HTTP REST services can be secured with a JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. ... Before version XX: "weed filer -disableHttp", disable http operations, only gRPC operations are allowed. This works with "weed mount" by FUSE. It does **not work** with the [S3 Gateway](Amazon S3 API), as this does HTTP calls to the Filer. Starting with version XX: secured by JWT, by setting `filer_jwt.signing.key` and `filer_jwt.signing.read.key` in `security.toml`. **This now works with the [S3 Gateway](Amazon S3 API).** ... # Securing Filer HTTP with JWT To enable JWT-based access control for the Filer, 1. generate `security.toml` file by `weed scaffold -config=security` 2. set `filer_jwt.signing.key` to a secret string - and optionally filer_jwt.signing.read.key` as well to a secret string 3. copy the same `security.toml` file to the filers and all S3 proxies. If `filer_jwt.signing.key` is configured: When sending upload/update/delete HTTP operations to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.key`. If `filer_jwt.signing.read.key` is configured: When sending GET or HEAD requests to a filer server, the request header `Authorization` should be the JWT string (`Authorization: Bearer [JwtToken]`). The operation is authorized after the filer validates the JWT with `filer_jwt.signing.read.key`. The S3 API Gateway reads the above JWT keys and sends authenticated HTTP requests to the filer. ``` Page `Security Configuration`: ``` (update scaffold file) ... [filer_jwt.signing] key = "blahblahblahblah" [filer_jwt.signing.read] key = "blahblahblahblah" ``` Resolves: #158
3 years ago
  1. package s3api
  2. import (
  3. "bytes"
  4. "crypto/md5"
  5. "encoding/json"
  6. "encoding/xml"
  7. "fmt"
  8. "github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
  9. "github.com/seaweedfs/seaweedfs/weed/security"
  10. "github.com/seaweedfs/seaweedfs/weed/util/mem"
  11. "golang.org/x/exp/slices"
  12. "io"
  13. "net/http"
  14. "net/url"
  15. "strings"
  16. "time"
  17. "github.com/pquerna/cachecontrol/cacheobject"
  18. "github.com/seaweedfs/seaweedfs/weed/filer"
  19. "github.com/seaweedfs/seaweedfs/weed/s3api/s3err"
  20. "github.com/seaweedfs/seaweedfs/weed/glog"
  21. "github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
  22. weed_server "github.com/seaweedfs/seaweedfs/weed/server"
  23. "github.com/seaweedfs/seaweedfs/weed/util"
  24. )
  25. const (
  26. deleteMultipleObjectsLimit = 1000
  27. )
  28. func mimeDetect(r *http.Request, dataReader io.Reader) io.ReadCloser {
  29. mimeBuffer := make([]byte, 512)
  30. size, _ := dataReader.Read(mimeBuffer)
  31. if size > 0 {
  32. r.Header.Set("Content-Type", http.DetectContentType(mimeBuffer[:size]))
  33. return io.NopCloser(io.MultiReader(bytes.NewReader(mimeBuffer[:size]), dataReader))
  34. }
  35. return io.NopCloser(dataReader)
  36. }
  37. func (s3a *S3ApiServer) PutObjectHandler(w http.ResponseWriter, r *http.Request) {
  38. // http://docs.aws.amazon.com/AmazonS3/latest/dev/UploadingObjects.html
  39. bucket, object := s3_constants.GetBucketAndObject(r)
  40. glog.V(3).Infof("PutObjectHandler %s %s", bucket, object)
  41. _, err := validateContentMd5(r.Header)
  42. if err != nil {
  43. s3err.WriteErrorResponse(w, r, s3err.ErrInvalidDigest)
  44. return
  45. }
  46. if r.Header.Get("Cache-Control") != "" {
  47. if _, err = cacheobject.ParseRequestCacheControl(r.Header.Get("Cache-Control")); err != nil {
  48. s3err.WriteErrorResponse(w, r, s3err.ErrInvalidDigest)
  49. return
  50. }
  51. }
  52. if r.Header.Get("Expires") != "" {
  53. if _, err = time.Parse(http.TimeFormat, r.Header.Get("Expires")); err != nil {
  54. s3err.WriteErrorResponse(w, r, s3err.ErrMalformedExpires)
  55. return
  56. }
  57. }
  58. dataReader := r.Body
  59. rAuthType := getRequestAuthType(r)
  60. if s3a.iam.isEnabled() {
  61. var s3ErrCode s3err.ErrorCode
  62. switch rAuthType {
  63. case authTypeStreamingSigned:
  64. dataReader, s3ErrCode = s3a.iam.newSignV4ChunkedReader(r)
  65. case authTypeSignedV2, authTypePresignedV2:
  66. _, s3ErrCode = s3a.iam.isReqAuthenticatedV2(r)
  67. case authTypePresigned, authTypeSigned:
  68. _, s3ErrCode = s3a.iam.reqSignatureV4Verify(r)
  69. }
  70. if s3ErrCode != s3err.ErrNone {
  71. s3err.WriteErrorResponse(w, r, s3ErrCode)
  72. return
  73. }
  74. } else {
  75. if authTypeStreamingSigned == rAuthType {
  76. s3err.WriteErrorResponse(w, r, s3err.ErrAuthNotSetup)
  77. return
  78. }
  79. }
  80. defer dataReader.Close()
  81. objectContentType := r.Header.Get("Content-Type")
  82. if strings.HasSuffix(object, "/") && r.ContentLength == 0 {
  83. if err := s3a.mkdir(
  84. s3a.option.BucketsPath, bucket+strings.TrimSuffix(object, "/"),
  85. func(entry *filer_pb.Entry) {
  86. if objectContentType == "" {
  87. objectContentType = "httpd/unix-directory"
  88. }
  89. entry.Attributes.Mime = objectContentType
  90. }); err != nil {
  91. s3err.WriteErrorResponse(w, r, s3err.ErrInternalError)
  92. return
  93. }
  94. } else {
  95. uploadUrl := s3a.toFilerUrl(bucket, object)
  96. if objectContentType == "" {
  97. dataReader = mimeDetect(r, dataReader)
  98. }
  99. etag, errCode := s3a.putToFiler(r, uploadUrl, dataReader, "")
  100. if errCode != s3err.ErrNone {
  101. s3err.WriteErrorResponse(w, r, errCode)
  102. return
  103. }
  104. setEtag(w, etag)
  105. }
  106. writeSuccessResponseEmpty(w, r)
  107. }
  108. func urlPathEscape(object string) string {
  109. var escapedParts []string
  110. for _, part := range strings.Split(object, "/") {
  111. escapedParts = append(escapedParts, url.PathEscape(part))
  112. }
  113. return strings.Join(escapedParts, "/")
  114. }
  115. func removeDuplicateSlashes(object string) string {
  116. result := strings.Builder{}
  117. result.Grow(len(object))
  118. isLastSlash := false
  119. for _, r := range object {
  120. switch r {
  121. case '/':
  122. if !isLastSlash {
  123. result.WriteRune(r)
  124. }
  125. isLastSlash = true
  126. default:
  127. result.WriteRune(r)
  128. isLastSlash = false
  129. }
  130. }
  131. return result.String()
  132. }
  133. func (s3a *S3ApiServer) toFilerUrl(bucket, object string) string {
  134. object = urlPathEscape(removeDuplicateSlashes(object))
  135. destUrl := fmt.Sprintf("http://%s%s/%s%s",
  136. s3a.option.Filer.ToHttpAddress(), s3a.option.BucketsPath, bucket, object)
  137. return destUrl
  138. }
  139. func (s3a *S3ApiServer) GetObjectHandler(w http.ResponseWriter, r *http.Request) {
  140. bucket, object := s3_constants.GetBucketAndObject(r)
  141. glog.V(3).Infof("GetObjectHandler %s %s", bucket, object)
  142. if strings.HasSuffix(r.URL.Path, "/") {
  143. s3err.WriteErrorResponse(w, r, s3err.ErrNotImplemented)
  144. return
  145. }
  146. destUrl := s3a.toFilerUrl(bucket, object)
  147. s3a.proxyToFiler(w, r, destUrl, false, passThroughResponse)
  148. }
  149. func (s3a *S3ApiServer) HeadObjectHandler(w http.ResponseWriter, r *http.Request) {
  150. bucket, object := s3_constants.GetBucketAndObject(r)
  151. glog.V(3).Infof("HeadObjectHandler %s %s", bucket, object)
  152. destUrl := s3a.toFilerUrl(bucket, object)
  153. s3a.proxyToFiler(w, r, destUrl, false, passThroughResponse)
  154. }
  155. func (s3a *S3ApiServer) DeleteObjectHandler(w http.ResponseWriter, r *http.Request) {
  156. bucket, object := s3_constants.GetBucketAndObject(r)
  157. glog.V(3).Infof("DeleteObjectHandler %s %s", bucket, object)
  158. destUrl := s3a.toFilerUrl(bucket, object)
  159. s3a.proxyToFiler(w, r, destUrl, true, func(proxyResponse *http.Response, w http.ResponseWriter) (statusCode int) {
  160. statusCode = http.StatusNoContent
  161. for k, v := range proxyResponse.Header {
  162. w.Header()[k] = v
  163. }
  164. w.WriteHeader(statusCode)
  165. return statusCode
  166. })
  167. }
  168. // / ObjectIdentifier carries key name for the object to delete.
  169. type ObjectIdentifier struct {
  170. ObjectName string `xml:"Key"`
  171. }
  172. // DeleteObjectsRequest - xml carrying the object key names which needs to be deleted.
  173. type DeleteObjectsRequest struct {
  174. // Element to enable quiet mode for the request
  175. Quiet bool
  176. // List of objects to be deleted
  177. Objects []ObjectIdentifier `xml:"Object"`
  178. }
  179. // DeleteError structure.
  180. type DeleteError struct {
  181. Code string
  182. Message string
  183. Key string
  184. }
  185. // DeleteObjectsResponse container for multiple object deletes.
  186. type DeleteObjectsResponse struct {
  187. XMLName xml.Name `xml:"http://s3.amazonaws.com/doc/2006-03-01/ DeleteResult" json:"-"`
  188. // Collection of all deleted objects
  189. DeletedObjects []ObjectIdentifier `xml:"Deleted,omitempty"`
  190. // Collection of errors deleting certain objects.
  191. Errors []DeleteError `xml:"Error,omitempty"`
  192. }
  193. // DeleteMultipleObjectsHandler - Delete multiple objects
  194. func (s3a *S3ApiServer) DeleteMultipleObjectsHandler(w http.ResponseWriter, r *http.Request) {
  195. bucket, _ := s3_constants.GetBucketAndObject(r)
  196. glog.V(3).Infof("DeleteMultipleObjectsHandler %s", bucket)
  197. deleteXMLBytes, err := io.ReadAll(r.Body)
  198. if err != nil {
  199. s3err.WriteErrorResponse(w, r, s3err.ErrInternalError)
  200. return
  201. }
  202. deleteObjects := &DeleteObjectsRequest{}
  203. if err := xml.Unmarshal(deleteXMLBytes, deleteObjects); err != nil {
  204. s3err.WriteErrorResponse(w, r, s3err.ErrMalformedXML)
  205. return
  206. }
  207. if len(deleteObjects.Objects) > deleteMultipleObjectsLimit {
  208. s3err.WriteErrorResponse(w, r, s3err.ErrInvalidMaxDeleteObjects)
  209. return
  210. }
  211. var deletedObjects []ObjectIdentifier
  212. var deleteErrors []DeleteError
  213. var auditLog *s3err.AccessLog
  214. directoriesWithDeletion := make(map[string]int)
  215. if s3err.Logger != nil {
  216. auditLog = s3err.GetAccessLog(r, http.StatusNoContent, s3err.ErrNone)
  217. }
  218. s3a.WithFilerClient(false, func(client filer_pb.SeaweedFilerClient) error {
  219. // delete file entries
  220. for _, object := range deleteObjects.Objects {
  221. lastSeparator := strings.LastIndex(object.ObjectName, "/")
  222. parentDirectoryPath, entryName, isDeleteData, isRecursive := "", object.ObjectName, true, false
  223. if lastSeparator > 0 && lastSeparator+1 < len(object.ObjectName) {
  224. entryName = object.ObjectName[lastSeparator+1:]
  225. parentDirectoryPath = "/" + object.ObjectName[:lastSeparator]
  226. }
  227. parentDirectoryPath = fmt.Sprintf("%s/%s%s", s3a.option.BucketsPath, bucket, parentDirectoryPath)
  228. err := doDeleteEntry(client, parentDirectoryPath, entryName, isDeleteData, isRecursive)
  229. if err == nil {
  230. directoriesWithDeletion[parentDirectoryPath]++
  231. deletedObjects = append(deletedObjects, object)
  232. } else if strings.Contains(err.Error(), filer.MsgFailDelNonEmptyFolder) {
  233. deletedObjects = append(deletedObjects, object)
  234. } else {
  235. delete(directoriesWithDeletion, parentDirectoryPath)
  236. deleteErrors = append(deleteErrors, DeleteError{
  237. Code: "",
  238. Message: err.Error(),
  239. Key: object.ObjectName,
  240. })
  241. }
  242. if auditLog != nil {
  243. auditLog.Key = entryName
  244. s3err.PostAccessLog(*auditLog)
  245. }
  246. }
  247. // purge empty folders, only checking folders with deletions
  248. for len(directoriesWithDeletion) > 0 {
  249. directoriesWithDeletion = s3a.doDeleteEmptyDirectories(client, directoriesWithDeletion)
  250. }
  251. return nil
  252. })
  253. deleteResp := DeleteObjectsResponse{}
  254. if !deleteObjects.Quiet {
  255. deleteResp.DeletedObjects = deletedObjects
  256. }
  257. deleteResp.Errors = deleteErrors
  258. writeSuccessResponseXML(w, r, deleteResp)
  259. }
  260. func (s3a *S3ApiServer) doDeleteEmptyDirectories(client filer_pb.SeaweedFilerClient, directoriesWithDeletion map[string]int) (newDirectoriesWithDeletion map[string]int) {
  261. var allDirs []string
  262. for dir := range directoriesWithDeletion {
  263. allDirs = append(allDirs, dir)
  264. }
  265. slices.SortFunc(allDirs, func(a, b string) bool {
  266. return len(a) > len(b)
  267. })
  268. newDirectoriesWithDeletion = make(map[string]int)
  269. for _, dir := range allDirs {
  270. parentDir, dirName := util.FullPath(dir).DirAndName()
  271. if parentDir == s3a.option.BucketsPath {
  272. continue
  273. }
  274. if err := doDeleteEntry(client, parentDir, dirName, false, false); err != nil {
  275. glog.V(4).Infof("directory %s has %d deletion but still not empty: %v", dir, directoriesWithDeletion[dir], err)
  276. } else {
  277. newDirectoriesWithDeletion[parentDir]++
  278. }
  279. }
  280. return
  281. }
  282. func (s3a *S3ApiServer) proxyToFiler(w http.ResponseWriter, r *http.Request, destUrl string, isWrite bool, responseFn func(proxyResponse *http.Response, w http.ResponseWriter) (statusCode int)) {
  283. glog.V(3).Infof("s3 proxying %s to %s", r.Method, destUrl)
  284. proxyReq, err := http.NewRequest(r.Method, destUrl, r.Body)
  285. if err != nil {
  286. glog.Errorf("NewRequest %s: %v", destUrl, err)
  287. s3err.WriteErrorResponse(w, r, s3err.ErrInternalError)
  288. return
  289. }
  290. proxyReq.Header.Set("X-Forwarded-For", r.RemoteAddr)
  291. for k, v := range r.URL.Query() {
  292. if _, ok := s3_constants.PassThroughHeaders[strings.ToLower(k)]; ok {
  293. proxyReq.Header[k] = v
  294. }
  295. }
  296. for header, values := range r.Header {
  297. proxyReq.Header[header] = values
  298. }
  299. // ensure that the Authorization header is overriding any previous
  300. // Authorization header which might be already present in proxyReq
  301. s3a.maybeAddFilerJwtAuthorization(proxyReq, isWrite)
  302. resp, postErr := s3a.client.Do(proxyReq)
  303. if postErr != nil {
  304. glog.Errorf("post to filer: %v", postErr)
  305. s3err.WriteErrorResponse(w, r, s3err.ErrInternalError)
  306. return
  307. }
  308. defer util.CloseResponse(resp)
  309. if resp.StatusCode == http.StatusPreconditionFailed {
  310. s3err.WriteErrorResponse(w, r, s3err.ErrPreconditionFailed)
  311. return
  312. }
  313. if resp.StatusCode == http.StatusRequestedRangeNotSatisfiable {
  314. s3err.WriteErrorResponse(w, r, s3err.ErrInvalidRange)
  315. return
  316. }
  317. if r.Method == "DELETE" {
  318. if resp.StatusCode == http.StatusNotFound {
  319. // this is normal
  320. responseStatusCode := responseFn(resp, w)
  321. s3err.PostLog(r, responseStatusCode, s3err.ErrNone)
  322. return
  323. }
  324. }
  325. if resp.StatusCode == http.StatusNotFound {
  326. s3err.WriteErrorResponse(w, r, s3err.ErrNoSuchKey)
  327. return
  328. }
  329. if resp.Header.Get(s3_constants.X_SeaweedFS_Header_Directory_Key) == "true" {
  330. responseStatusCode := responseFn(resp, w)
  331. s3err.PostLog(r, responseStatusCode, s3err.ErrNone)
  332. return
  333. }
  334. // when HEAD a directory, it should be reported as no such key
  335. // https://github.com/seaweedfs/seaweedfs/issues/3457
  336. if resp.ContentLength == -1 && resp.StatusCode != http.StatusNotModified {
  337. s3err.WriteErrorResponse(w, r, s3err.ErrNoSuchKey)
  338. return
  339. }
  340. responseStatusCode := responseFn(resp, w)
  341. s3err.PostLog(r, responseStatusCode, s3err.ErrNone)
  342. }
  343. func passThroughResponse(proxyResponse *http.Response, w http.ResponseWriter) (statusCode int) {
  344. for k, v := range proxyResponse.Header {
  345. w.Header()[k] = v
  346. }
  347. if proxyResponse.Header.Get("Content-Range") != "" && proxyResponse.StatusCode == 200 {
  348. w.WriteHeader(http.StatusPartialContent)
  349. statusCode = http.StatusPartialContent
  350. } else {
  351. statusCode = proxyResponse.StatusCode
  352. }
  353. w.WriteHeader(statusCode)
  354. buf := mem.Allocate(128 * 1024)
  355. defer mem.Free(buf)
  356. if n, err := io.CopyBuffer(w, proxyResponse.Body, buf); err != nil {
  357. glog.V(1).Infof("passthrough response read %d bytes: %v", n, err)
  358. }
  359. return statusCode
  360. }
  361. func (s3a *S3ApiServer) putToFiler(r *http.Request, uploadUrl string, dataReader io.Reader, destination string) (etag string, code s3err.ErrorCode) {
  362. hash := md5.New()
  363. var body = io.TeeReader(dataReader, hash)
  364. proxyReq, err := http.NewRequest("PUT", uploadUrl, body)
  365. if err != nil {
  366. glog.Errorf("NewRequest %s: %v", uploadUrl, err)
  367. return "", s3err.ErrInternalError
  368. }
  369. proxyReq.Header.Set("X-Forwarded-For", r.RemoteAddr)
  370. if destination != "" {
  371. proxyReq.Header.Set(s3_constants.SeaweedStorageDestinationHeader, destination)
  372. }
  373. for header, values := range r.Header {
  374. for _, value := range values {
  375. proxyReq.Header.Add(header, value)
  376. }
  377. }
  378. // ensure that the Authorization header is overriding any previous
  379. // Authorization header which might be already present in proxyReq
  380. s3a.maybeAddFilerJwtAuthorization(proxyReq, true)
  381. resp, postErr := s3a.client.Do(proxyReq)
  382. if postErr != nil {
  383. glog.Errorf("post to filer: %v", postErr)
  384. return "", s3err.ErrInternalError
  385. }
  386. defer resp.Body.Close()
  387. etag = fmt.Sprintf("%x", hash.Sum(nil))
  388. resp_body, ra_err := io.ReadAll(resp.Body)
  389. if ra_err != nil {
  390. glog.Errorf("upload to filer response read %d: %v", resp.StatusCode, ra_err)
  391. return etag, s3err.ErrInternalError
  392. }
  393. var ret weed_server.FilerPostResult
  394. unmarshal_err := json.Unmarshal(resp_body, &ret)
  395. if unmarshal_err != nil {
  396. glog.Errorf("failing to read upload to %s : %v", uploadUrl, string(resp_body))
  397. return "", s3err.ErrInternalError
  398. }
  399. if ret.Error != "" {
  400. glog.Errorf("upload to filer error: %v", ret.Error)
  401. return "", filerErrorToS3Error(ret.Error)
  402. }
  403. return etag, s3err.ErrNone
  404. }
  405. func setEtag(w http.ResponseWriter, etag string) {
  406. if etag != "" {
  407. if strings.HasPrefix(etag, "\"") {
  408. w.Header()["ETag"] = []string{etag}
  409. } else {
  410. w.Header()["ETag"] = []string{"\"" + etag + "\""}
  411. }
  412. }
  413. }
  414. func filerErrorToS3Error(errString string) s3err.ErrorCode {
  415. switch {
  416. case strings.HasPrefix(errString, "existing ") && strings.HasSuffix(errString, "is a directory"):
  417. return s3err.ErrExistingObjectIsDirectory
  418. case strings.HasSuffix(errString, "is a file"):
  419. return s3err.ErrExistingObjectIsFile
  420. default:
  421. return s3err.ErrInternalError
  422. }
  423. }
  424. func (s3a *S3ApiServer) maybeAddFilerJwtAuthorization(r *http.Request, isWrite bool) {
  425. encodedJwt := s3a.maybeGetFilerJwtAuthorizationToken(isWrite)
  426. if encodedJwt == "" {
  427. return
  428. }
  429. r.Header.Set("Authorization", "BEARER "+string(encodedJwt))
  430. }
  431. func (s3a *S3ApiServer) maybeGetFilerJwtAuthorizationToken(isWrite bool) string {
  432. var encodedJwt security.EncodedJwt
  433. if isWrite {
  434. encodedJwt = security.GenJwtForFilerServer(s3a.filerGuard.SigningKey, s3a.filerGuard.ExpiresAfterSec)
  435. } else {
  436. encodedJwt = security.GenJwtForFilerServer(s3a.filerGuard.ReadSigningKey, s3a.filerGuard.ReadExpiresAfterSec)
  437. }
  438. return string(encodedJwt)
  439. }