You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

198 lines
5.5 KiB

7 years ago
7 years ago
7 years ago
7 years ago
7 years ago
avoid slice out of bounds avoid this problem 2018/09/04 16:27:14 fuse: panic in handler for Write [ID=0x27c0d Node=0x2 Uid=0 Gid=0 Pid=0] 0x1 131072 @10607788032 fl=WriteCache lock=0 ffl=OpenReadOnly: runtime error: slice bounds out of range goroutine 211141 [running]: bazil.org/fuse/fs.(*Server).serve.func2(0x10d3e60, 0xc00014be30, 0xc00052fef8, 0xc00052fe77) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:857 +0x1ac panic(0xe2d080, 0x17f62b0) /home/travis/.gimme/versions/go/src/runtime/panic.go:513 +0x1b9 github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).saveToStorage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0xc0005dc000, 0x20000, 0x1000000, 0x276720000, 0xc0003feaa0, 0x0, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:142 +0x8ec github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).saveExistingPagesToStorage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0x0, 0x0, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:107 +0x6c github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).AddPage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0x278460000, 0xc011966050, 0x20000, 0x20fb0, 0x6fc23ac00, 0x4a817c800, 0x0, ...) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:70 +0x8f github.com/chrislusf/seaweedfs/weed/filesys.(*FileHandle).Write(0xc000548410, 0x10d7ba0, 0xc0003fcc00, 0xc00014be30, 0xc011946af8, 0x47fa01, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/filehandle.go:141 +0x245 bazil.org/fuse/fs.(*Server).handleRequest(0xc0002cc0c0, 0x10d7ba0, 0xc0003fcc00, 0x10cb020, 0xc000394140, 0xc0000acac0, 0x10d3e60, 0xc00014be30, 0xc00052fef8, 0x10ca6a0, ...) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:1265 +0x1599 bazil.org/fuse/fs.(*Server).serve(0xc0002cc0c0, 0x10d3e60, 0xc00014be30) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:878 +0x410 bazil.org/fuse/fs.(*Server).Serve.func1(0xc0002cc0c0, 0x10d3e60, 0xc00014be30) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:425 +0x6e created by bazil.org/fuse/fs.(*Server).Serve /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:423 +0x321
6 years ago
  1. package filesys
  2. import (
  3. "bytes"
  4. "context"
  5. "fmt"
  6. "time"
  7. "github.com/chrislusf/seaweedfs/weed/glog"
  8. "github.com/chrislusf/seaweedfs/weed/operation"
  9. "github.com/chrislusf/seaweedfs/weed/pb/filer_pb"
  10. "sync"
  11. )
  12. type ContinuousDirtyPages struct {
  13. hasData bool
  14. Offset int64
  15. Size int64
  16. Data []byte
  17. f *File
  18. lock sync.Mutex
  19. }
  20. func newDirtyPages(file *File) *ContinuousDirtyPages {
  21. return &ContinuousDirtyPages{
  22. Data: make([]byte, file.wfs.option.ChunkSizeLimit),
  23. f: file,
  24. }
  25. }
  26. func (pages *ContinuousDirtyPages) AddPage(ctx context.Context, offset int64, data []byte) (chunks []*filer_pb.FileChunk, err error) {
  27. pages.lock.Lock()
  28. defer pages.lock.Unlock()
  29. var chunk *filer_pb.FileChunk
  30. if len(data) > len(pages.Data) {
  31. // this is more than what buffer can hold.
  32. return pages.flushAndSave(ctx, offset, data)
  33. }
  34. if offset < pages.Offset || offset >= pages.Offset+int64(len(pages.Data)) ||
  35. pages.Offset+int64(len(pages.Data)) < offset+int64(len(data)) {
  36. // if the data is out of range,
  37. // or buffer is full if adding new data,
  38. // flush current buffer and add new data
  39. // println("offset", offset, "size", len(data), "existing offset", pages.Offset, "size", pages.Size)
  40. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  41. if chunk != nil {
  42. glog.V(4).Infof("%s/%s add save [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  43. chunks = append(chunks, chunk)
  44. }
  45. } else {
  46. glog.V(0).Infof("%s/%s add save [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  47. return
  48. }
  49. pages.Offset = offset
  50. copy(pages.Data, data)
  51. pages.Size = int64(len(data))
  52. return
  53. }
  54. if offset != pages.Offset+pages.Size {
  55. // when this happens, debug shows the data overlapping with existing data is empty
  56. // the data is not just append
  57. if offset == pages.Offset {
  58. copy(pages.Data[pages.Size:], data[pages.Size:])
  59. } else {
  60. if pages.Size != 0 {
  61. glog.V(0).Infof("possible error: pages [%d, %d) write [%d, %d)", pages.Offset, pages.Offset+pages.Size, offset, offset+int64(len(data)))
  62. }
  63. return pages.flushAndSave(ctx, offset, data)
  64. }
  65. } else {
  66. copy(pages.Data[offset-pages.Offset:], data)
  67. }
  68. pages.Size = max(pages.Size, offset+int64(len(data))-pages.Offset)
  69. return
  70. }
  71. func (pages *ContinuousDirtyPages) flushAndSave(ctx context.Context, offset int64, data []byte) (chunks []*filer_pb.FileChunk, err error) {
  72. var chunk *filer_pb.FileChunk
  73. // flush existing
  74. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  75. if chunk != nil {
  76. glog.V(4).Infof("%s/%s flush existing [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  77. chunks = append(chunks, chunk)
  78. }
  79. } else {
  80. glog.V(0).Infof("%s/%s failed to flush1 [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  81. return
  82. }
  83. pages.Size = 0
  84. pages.Offset = 0
  85. // flush the new page
  86. if chunk, err = pages.saveToStorage(ctx, data, offset); err == nil {
  87. if chunk != nil {
  88. glog.V(4).Infof("%s/%s flush big request [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  89. chunks = append(chunks, chunk)
  90. }
  91. } else {
  92. glog.V(0).Infof("%s/%s failed to flush2 [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  93. return
  94. }
  95. return
  96. }
  97. func (pages *ContinuousDirtyPages) FlushToStorage(ctx context.Context) (chunk *filer_pb.FileChunk, err error) {
  98. pages.lock.Lock()
  99. defer pages.lock.Unlock()
  100. if pages.Size == 0 {
  101. return nil, nil
  102. }
  103. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  104. pages.Size = 0
  105. pages.Offset = 0
  106. if chunk != nil {
  107. glog.V(4).Infof("%s/%s flush [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  108. }
  109. }
  110. return
  111. }
  112. func (pages *ContinuousDirtyPages) saveExistingPagesToStorage(ctx context.Context) (*filer_pb.FileChunk, error) {
  113. if pages.Size == 0 {
  114. return nil, nil
  115. }
  116. return pages.saveToStorage(ctx, pages.Data[:pages.Size], pages.Offset)
  117. }
  118. func (pages *ContinuousDirtyPages) saveToStorage(ctx context.Context, buf []byte, offset int64) (*filer_pb.FileChunk, error) {
  119. var fileId, host string
  120. if err := pages.f.wfs.withFilerClient(func(client filer_pb.SeaweedFilerClient) error {
  121. request := &filer_pb.AssignVolumeRequest{
  122. Count: 1,
  123. Replication: pages.f.wfs.option.Replication,
  124. Collection: pages.f.wfs.option.Collection,
  125. TtlSec: pages.f.wfs.option.TtlSec,
  126. DataCenter: pages.f.wfs.option.DataCenter,
  127. }
  128. resp, err := client.AssignVolume(ctx, request)
  129. if err != nil {
  130. glog.V(0).Infof("assign volume failure %v: %v", request, err)
  131. return err
  132. }
  133. fileId, host = resp.FileId, resp.Url
  134. return nil
  135. }); err != nil {
  136. return nil, fmt.Errorf("filerGrpcAddress assign volume: %v", err)
  137. }
  138. fileUrl := fmt.Sprintf("http://%s/%s", host, fileId)
  139. bufReader := bytes.NewReader(buf)
  140. uploadResult, err := operation.Upload(fileUrl, pages.f.Name, bufReader, false, "application/octet-stream", nil, "")
  141. if err != nil {
  142. glog.V(0).Infof("upload data %v to %s: %v", pages.f.Name, fileUrl, err)
  143. return nil, fmt.Errorf("upload data: %v", err)
  144. }
  145. if uploadResult.Error != "" {
  146. glog.V(0).Infof("upload failure %v to %s: %v", pages.f.Name, fileUrl, err)
  147. return nil, fmt.Errorf("upload result: %v", uploadResult.Error)
  148. }
  149. return &filer_pb.FileChunk{
  150. FileId: fileId,
  151. Offset: offset,
  152. Size: uint64(len(buf)),
  153. Mtime: time.Now().UnixNano(),
  154. }, nil
  155. }
  156. func max(x, y int64) int64 {
  157. if x > y {
  158. return x
  159. }
  160. return y
  161. }