You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

216 lines
6.0 KiB

7 years ago
7 years ago
7 years ago
6 years ago
7 years ago
7 years ago
avoid slice out of bounds avoid this problem 2018/09/04 16:27:14 fuse: panic in handler for Write [ID=0x27c0d Node=0x2 Uid=0 Gid=0 Pid=0] 0x1 131072 @10607788032 fl=WriteCache lock=0 ffl=OpenReadOnly: runtime error: slice bounds out of range goroutine 211141 [running]: bazil.org/fuse/fs.(*Server).serve.func2(0x10d3e60, 0xc00014be30, 0xc00052fef8, 0xc00052fe77) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:857 +0x1ac panic(0xe2d080, 0x17f62b0) /home/travis/.gimme/versions/go/src/runtime/panic.go:513 +0x1b9 github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).saveToStorage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0xc0005dc000, 0x20000, 0x1000000, 0x276720000, 0xc0003feaa0, 0x0, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:142 +0x8ec github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).saveExistingPagesToStorage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0x0, 0x0, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:107 +0x6c github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).AddPage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0x278460000, 0xc011966050, 0x20000, 0x20fb0, 0x6fc23ac00, 0x4a817c800, 0x0, ...) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:70 +0x8f github.com/chrislusf/seaweedfs/weed/filesys.(*FileHandle).Write(0xc000548410, 0x10d7ba0, 0xc0003fcc00, 0xc00014be30, 0xc011946af8, 0x47fa01, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/filehandle.go:141 +0x245 bazil.org/fuse/fs.(*Server).handleRequest(0xc0002cc0c0, 0x10d7ba0, 0xc0003fcc00, 0x10cb020, 0xc000394140, 0xc0000acac0, 0x10d3e60, 0xc00014be30, 0xc00052fef8, 0x10ca6a0, ...) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:1265 +0x1599 bazil.org/fuse/fs.(*Server).serve(0xc0002cc0c0, 0x10d3e60, 0xc00014be30) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:878 +0x410 bazil.org/fuse/fs.(*Server).Serve.func1(0xc0002cc0c0, 0x10d3e60, 0xc00014be30) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:425 +0x6e created by bazil.org/fuse/fs.(*Server).Serve /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:423 +0x321
6 years ago
  1. package filesys
  2. import (
  3. "bytes"
  4. "context"
  5. "fmt"
  6. "time"
  7. "github.com/chrislusf/seaweedfs/weed/glog"
  8. "github.com/chrislusf/seaweedfs/weed/operation"
  9. "github.com/chrislusf/seaweedfs/weed/pb/filer_pb"
  10. "sync"
  11. )
  12. type ContinuousDirtyPages struct {
  13. hasData bool
  14. Offset int64
  15. Size int64
  16. Data []byte
  17. f *File
  18. lock sync.Mutex
  19. }
  20. var bufPool = sync.Pool{
  21. New: func() interface{} {
  22. return new(bytes.Buffer)
  23. },
  24. }
  25. func newDirtyPages(file *File) *ContinuousDirtyPages {
  26. return &ContinuousDirtyPages{
  27. Data: nil,
  28. f: file,
  29. }
  30. }
  31. func (pages *ContinuousDirtyPages) releaseResource() {
  32. if pages.Data != nil {
  33. pages.f.wfs.bufPool.Put(pages.Data)
  34. }
  35. }
  36. func (pages *ContinuousDirtyPages) AddPage(ctx context.Context, offset int64, data []byte) (chunks []*filer_pb.FileChunk, err error) {
  37. pages.lock.Lock()
  38. defer pages.lock.Unlock()
  39. var chunk *filer_pb.FileChunk
  40. if pages.Data == nil {
  41. pages.Data = pages.f.wfs.bufPool.Get().([]byte)
  42. }
  43. if len(data) > len(pages.Data) {
  44. // this is more than what buffer can hold.
  45. return pages.flushAndSave(ctx, offset, data)
  46. }
  47. if offset < pages.Offset || offset >= pages.Offset+int64(len(pages.Data)) ||
  48. pages.Offset+int64(len(pages.Data)) < offset+int64(len(data)) {
  49. // if the data is out of range,
  50. // or buffer is full if adding new data,
  51. // flush current buffer and add new data
  52. // println("offset", offset, "size", len(data), "existing offset", pages.Offset, "size", pages.Size)
  53. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  54. if chunk != nil {
  55. glog.V(4).Infof("%s/%s add save [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  56. chunks = append(chunks, chunk)
  57. }
  58. } else {
  59. glog.V(0).Infof("%s/%s add save [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  60. return
  61. }
  62. pages.Offset = offset
  63. copy(pages.Data, data)
  64. pages.Size = int64(len(data))
  65. return
  66. }
  67. if offset != pages.Offset+pages.Size {
  68. // when this happens, debug shows the data overlapping with existing data is empty
  69. // the data is not just append
  70. if offset == pages.Offset && int(pages.Size) < len(data) {
  71. // glog.V(2).Infof("pages[%d,%d) pages.Data len=%v, data len=%d, pages.Size=%d", pages.Offset, pages.Offset+pages.Size, len(pages.Data), len(data), pages.Size)
  72. copy(pages.Data[pages.Size:], data[pages.Size:])
  73. } else {
  74. if pages.Size != 0 {
  75. glog.V(1).Infof("%s/%s add page: pages [%d, %d) write [%d, %d)", pages.f.dir.Path, pages.f.Name, pages.Offset, pages.Offset+pages.Size, offset, offset+int64(len(data)))
  76. }
  77. return pages.flushAndSave(ctx, offset, data)
  78. }
  79. } else {
  80. copy(pages.Data[offset-pages.Offset:], data)
  81. }
  82. pages.Size = max(pages.Size, offset+int64(len(data))-pages.Offset)
  83. return
  84. }
  85. func (pages *ContinuousDirtyPages) flushAndSave(ctx context.Context, offset int64, data []byte) (chunks []*filer_pb.FileChunk, err error) {
  86. var chunk *filer_pb.FileChunk
  87. // flush existing
  88. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  89. if chunk != nil {
  90. glog.V(4).Infof("%s/%s flush existing [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  91. chunks = append(chunks, chunk)
  92. }
  93. } else {
  94. glog.V(0).Infof("%s/%s failed to flush1 [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  95. return
  96. }
  97. pages.Size = 0
  98. pages.Offset = 0
  99. // flush the new page
  100. if chunk, err = pages.saveToStorage(ctx, data, offset); err == nil {
  101. if chunk != nil {
  102. glog.V(4).Infof("%s/%s flush big request [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  103. chunks = append(chunks, chunk)
  104. }
  105. } else {
  106. glog.V(0).Infof("%s/%s failed to flush2 [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  107. return
  108. }
  109. return
  110. }
  111. func (pages *ContinuousDirtyPages) FlushToStorage(ctx context.Context) (chunk *filer_pb.FileChunk, err error) {
  112. pages.lock.Lock()
  113. defer pages.lock.Unlock()
  114. if pages.Size == 0 {
  115. return nil, nil
  116. }
  117. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  118. pages.Size = 0
  119. pages.Offset = 0
  120. if chunk != nil {
  121. glog.V(4).Infof("%s/%s flush [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  122. }
  123. }
  124. return
  125. }
  126. func (pages *ContinuousDirtyPages) saveExistingPagesToStorage(ctx context.Context) (*filer_pb.FileChunk, error) {
  127. if pages.Size == 0 {
  128. return nil, nil
  129. }
  130. return pages.saveToStorage(ctx, pages.Data[:pages.Size], pages.Offset)
  131. }
  132. func (pages *ContinuousDirtyPages) saveToStorage(ctx context.Context, buf []byte, offset int64) (*filer_pb.FileChunk, error) {
  133. var fileId, host string
  134. if err := pages.f.wfs.withFilerClient(func(client filer_pb.SeaweedFilerClient) error {
  135. request := &filer_pb.AssignVolumeRequest{
  136. Count: 1,
  137. Replication: pages.f.wfs.option.Replication,
  138. Collection: pages.f.wfs.option.Collection,
  139. TtlSec: pages.f.wfs.option.TtlSec,
  140. DataCenter: pages.f.wfs.option.DataCenter,
  141. }
  142. resp, err := client.AssignVolume(ctx, request)
  143. if err != nil {
  144. glog.V(0).Infof("assign volume failure %v: %v", request, err)
  145. return err
  146. }
  147. fileId, host = resp.FileId, resp.Url
  148. return nil
  149. }); err != nil {
  150. return nil, fmt.Errorf("filerGrpcAddress assign volume: %v", err)
  151. }
  152. fileUrl := fmt.Sprintf("http://%s/%s", host, fileId)
  153. bufReader := bytes.NewReader(buf)
  154. uploadResult, err := operation.Upload(fileUrl, pages.f.Name, bufReader, false, "application/octet-stream", nil, "")
  155. if err != nil {
  156. glog.V(0).Infof("upload data %v to %s: %v", pages.f.Name, fileUrl, err)
  157. return nil, fmt.Errorf("upload data: %v", err)
  158. }
  159. if uploadResult.Error != "" {
  160. glog.V(0).Infof("upload failure %v to %s: %v", pages.f.Name, fileUrl, err)
  161. return nil, fmt.Errorf("upload result: %v", uploadResult.Error)
  162. }
  163. return &filer_pb.FileChunk{
  164. FileId: fileId,
  165. Offset: offset,
  166. Size: uint64(len(buf)),
  167. Mtime: time.Now().UnixNano(),
  168. ETag: uploadResult.ETag,
  169. }, nil
  170. }
  171. func max(x, y int64) int64 {
  172. if x > y {
  173. return x
  174. }
  175. return y
  176. }