You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

208 lines
6.0 KiB

7 years ago
7 years ago
7 years ago
6 years ago
7 years ago
7 years ago
avoid slice out of bounds avoid this problem 2018/09/04 16:27:14 fuse: panic in handler for Write [ID=0x27c0d Node=0x2 Uid=0 Gid=0 Pid=0] 0x1 131072 @10607788032 fl=WriteCache lock=0 ffl=OpenReadOnly: runtime error: slice bounds out of range goroutine 211141 [running]: bazil.org/fuse/fs.(*Server).serve.func2(0x10d3e60, 0xc00014be30, 0xc00052fef8, 0xc00052fe77) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:857 +0x1ac panic(0xe2d080, 0x17f62b0) /home/travis/.gimme/versions/go/src/runtime/panic.go:513 +0x1b9 github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).saveToStorage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0xc0005dc000, 0x20000, 0x1000000, 0x276720000, 0xc0003feaa0, 0x0, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:142 +0x8ec github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).saveExistingPagesToStorage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0x0, 0x0, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:107 +0x6c github.com/chrislusf/seaweedfs/weed/filesys.(*ContinuousDirtyPages).AddPage(0xc0000aca80, 0x10d7ba0, 0xc0003fcc00, 0x278460000, 0xc011966050, 0x20000, 0x20fb0, 0x6fc23ac00, 0x4a817c800, 0x0, ...) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/dirty_page.go:70 +0x8f github.com/chrislusf/seaweedfs/weed/filesys.(*FileHandle).Write(0xc000548410, 0x10d7ba0, 0xc0003fcc00, 0xc00014be30, 0xc011946af8, 0x47fa01, 0x0) /home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/filesys/filehandle.go:141 +0x245 bazil.org/fuse/fs.(*Server).handleRequest(0xc0002cc0c0, 0x10d7ba0, 0xc0003fcc00, 0x10cb020, 0xc000394140, 0xc0000acac0, 0x10d3e60, 0xc00014be30, 0xc00052fef8, 0x10ca6a0, ...) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:1265 +0x1599 bazil.org/fuse/fs.(*Server).serve(0xc0002cc0c0, 0x10d3e60, 0xc00014be30) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:878 +0x410 bazil.org/fuse/fs.(*Server).Serve.func1(0xc0002cc0c0, 0x10d3e60, 0xc00014be30) /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:425 +0x6e created by bazil.org/fuse/fs.(*Server).Serve /home/travis/gopath/src/bazil.org/fuse/fs/serve.go:423 +0x321
6 years ago
  1. package filesys
  2. import (
  3. "bytes"
  4. "context"
  5. "fmt"
  6. "time"
  7. "github.com/chrislusf/seaweedfs/weed/glog"
  8. "github.com/chrislusf/seaweedfs/weed/operation"
  9. "github.com/chrislusf/seaweedfs/weed/pb/filer_pb"
  10. "sync"
  11. )
  12. type ContinuousDirtyPages struct {
  13. hasData bool
  14. Offset int64
  15. Size int64
  16. Data []byte
  17. f *File
  18. lock sync.Mutex
  19. }
  20. func newDirtyPages(file *File) *ContinuousDirtyPages {
  21. return &ContinuousDirtyPages{
  22. Data: make([]byte, file.wfs.option.ChunkSizeLimit),
  23. f: file,
  24. }
  25. }
  26. func (pages *ContinuousDirtyPages) InitializeToFile(file *File) *ContinuousDirtyPages {
  27. if len(pages.Data) != int(file.wfs.option.ChunkSizeLimit) {
  28. pages.Data = make([]byte, file.wfs.option.ChunkSizeLimit)
  29. }
  30. pages.f = file
  31. return pages
  32. }
  33. func (pages *ContinuousDirtyPages) AddPage(ctx context.Context, offset int64, data []byte) (chunks []*filer_pb.FileChunk, err error) {
  34. pages.lock.Lock()
  35. defer pages.lock.Unlock()
  36. var chunk *filer_pb.FileChunk
  37. if len(data) > len(pages.Data) {
  38. // this is more than what buffer can hold.
  39. return pages.flushAndSave(ctx, offset, data)
  40. }
  41. if offset < pages.Offset || offset >= pages.Offset+int64(len(pages.Data)) ||
  42. pages.Offset+int64(len(pages.Data)) < offset+int64(len(data)) {
  43. // if the data is out of range,
  44. // or buffer is full if adding new data,
  45. // flush current buffer and add new data
  46. // println("offset", offset, "size", len(data), "existing offset", pages.Offset, "size", pages.Size)
  47. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  48. if chunk != nil {
  49. glog.V(4).Infof("%s/%s add save [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  50. chunks = append(chunks, chunk)
  51. }
  52. } else {
  53. glog.V(0).Infof("%s/%s add save [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  54. return
  55. }
  56. pages.Offset = offset
  57. copy(pages.Data, data)
  58. pages.Size = int64(len(data))
  59. return
  60. }
  61. if offset != pages.Offset+pages.Size {
  62. // when this happens, debug shows the data overlapping with existing data is empty
  63. // the data is not just append
  64. if offset == pages.Offset && int(pages.Size) < len(data) {
  65. // glog.V(2).Infof("pages[%d,%d) pages.Data len=%v, data len=%d, pages.Size=%d", pages.Offset, pages.Offset+pages.Size, len(pages.Data), len(data), pages.Size)
  66. copy(pages.Data[pages.Size:], data[pages.Size:])
  67. } else {
  68. if pages.Size != 0 {
  69. glog.V(1).Infof("%s/%s add page: pages [%d, %d) write [%d, %d)", pages.f.dir.Path, pages.f.Name, pages.Offset, pages.Offset+pages.Size, offset, offset+int64(len(data)))
  70. }
  71. return pages.flushAndSave(ctx, offset, data)
  72. }
  73. } else {
  74. copy(pages.Data[offset-pages.Offset:], data)
  75. }
  76. pages.Size = max(pages.Size, offset+int64(len(data))-pages.Offset)
  77. return
  78. }
  79. func (pages *ContinuousDirtyPages) flushAndSave(ctx context.Context, offset int64, data []byte) (chunks []*filer_pb.FileChunk, err error) {
  80. var chunk *filer_pb.FileChunk
  81. // flush existing
  82. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  83. if chunk != nil {
  84. glog.V(4).Infof("%s/%s flush existing [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  85. chunks = append(chunks, chunk)
  86. }
  87. } else {
  88. glog.V(0).Infof("%s/%s failed to flush1 [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  89. return
  90. }
  91. pages.Size = 0
  92. pages.Offset = 0
  93. // flush the new page
  94. if chunk, err = pages.saveToStorage(ctx, data, offset); err == nil {
  95. if chunk != nil {
  96. glog.V(4).Infof("%s/%s flush big request [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  97. chunks = append(chunks, chunk)
  98. }
  99. } else {
  100. glog.V(0).Infof("%s/%s failed to flush2 [%d,%d): %v", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size), err)
  101. return
  102. }
  103. return
  104. }
  105. func (pages *ContinuousDirtyPages) FlushToStorage(ctx context.Context) (chunk *filer_pb.FileChunk, err error) {
  106. pages.lock.Lock()
  107. defer pages.lock.Unlock()
  108. if pages.Size == 0 {
  109. return nil, nil
  110. }
  111. if chunk, err = pages.saveExistingPagesToStorage(ctx); err == nil {
  112. pages.Size = 0
  113. pages.Offset = 0
  114. if chunk != nil {
  115. glog.V(4).Infof("%s/%s flush [%d,%d)", pages.f.dir.Path, pages.f.Name, chunk.Offset, chunk.Offset+int64(chunk.Size))
  116. }
  117. }
  118. return
  119. }
  120. func (pages *ContinuousDirtyPages) saveExistingPagesToStorage(ctx context.Context) (*filer_pb.FileChunk, error) {
  121. if pages.Size == 0 {
  122. return nil, nil
  123. }
  124. return pages.saveToStorage(ctx, pages.Data[:pages.Size], pages.Offset)
  125. }
  126. func (pages *ContinuousDirtyPages) saveToStorage(ctx context.Context, buf []byte, offset int64) (*filer_pb.FileChunk, error) {
  127. var fileId, host string
  128. if err := pages.f.wfs.withFilerClient(func(client filer_pb.SeaweedFilerClient) error {
  129. request := &filer_pb.AssignVolumeRequest{
  130. Count: 1,
  131. Replication: pages.f.wfs.option.Replication,
  132. Collection: pages.f.wfs.option.Collection,
  133. TtlSec: pages.f.wfs.option.TtlSec,
  134. DataCenter: pages.f.wfs.option.DataCenter,
  135. }
  136. resp, err := client.AssignVolume(ctx, request)
  137. if err != nil {
  138. glog.V(0).Infof("assign volume failure %v: %v", request, err)
  139. return err
  140. }
  141. fileId, host = resp.FileId, resp.Url
  142. return nil
  143. }); err != nil {
  144. return nil, fmt.Errorf("filerGrpcAddress assign volume: %v", err)
  145. }
  146. fileUrl := fmt.Sprintf("http://%s/%s", host, fileId)
  147. bufReader := bytes.NewReader(buf)
  148. uploadResult, err := operation.Upload(fileUrl, pages.f.Name, bufReader, false, "application/octet-stream", nil, "")
  149. if err != nil {
  150. glog.V(0).Infof("upload data %v to %s: %v", pages.f.Name, fileUrl, err)
  151. return nil, fmt.Errorf("upload data: %v", err)
  152. }
  153. if uploadResult.Error != "" {
  154. glog.V(0).Infof("upload failure %v to %s: %v", pages.f.Name, fileUrl, err)
  155. return nil, fmt.Errorf("upload result: %v", uploadResult.Error)
  156. }
  157. return &filer_pb.FileChunk{
  158. FileId: fileId,
  159. Offset: offset,
  160. Size: uint64(len(buf)),
  161. Mtime: time.Now().UnixNano(),
  162. ETag: uploadResult.ETag,
  163. }, nil
  164. }
  165. func max(x, y int64) int64 {
  166. if x > y {
  167. return x
  168. }
  169. return y
  170. }