fix: raise correct exceptions

src/keycloak/keycloak_admin.py

@@ -2736,7 +2736,7 @@ class KeycloakAdmin:
         else:
             try:
                 self.token = self.keycloak_openid.refresh_token(refresh_token)
-            except KeycloakGetError as e:
+            except KeycloakPostError as e:
                 list_errors = [
                     b"Refresh token expired",
                     b"Token is not active",

src/keycloak/keycloak_openid.py

@@ -229,7 +229,7 @@ class KeycloakOpenID:
 
         payload = self._add_secret_key(payload)
         data_raw = self.connection.raw_post(URL_TOKEN.format(**params_path), data=payload)
-        return raise_error_from_response(data_raw, KeycloakGetError)
+        return raise_error_from_response(data_raw, KeycloakPostError)
 
     def refresh_token(self, refresh_token, grant_type=["refresh_token"]):
         """
@@ -252,7 +252,7 @@ class KeycloakOpenID:
         }
         payload = self._add_secret_key(payload)
         data_raw = self.connection.raw_post(URL_TOKEN.format(**params_path), data=payload)
-        return raise_error_from_response(data_raw, KeycloakGetError)
+        return raise_error_from_response(data_raw, KeycloakPostError)
 
     def exchange_token(self, token: str, client_id: str, audience: str, subject: str) -> dict:
         """
@@ -276,7 +276,7 @@ class KeycloakOpenID:
         }
         payload = self._add_secret_key(payload)
         data_raw = self.connection.raw_post(URL_TOKEN.format(**params_path), data=payload)
-        return raise_error_from_response(data_raw, KeycloakGetError)
+        return raise_error_from_response(data_raw, KeycloakPostError)
 
     def userinfo(self, token):
         """
@@ -288,12 +288,9 @@ class KeycloakOpenID:
         :param token:
         :return:
         """
-
         self.connection.add_param_headers("Authorization", "Bearer " + token)
         params_path = {"realm-name": self.realm_name}
-
         data_raw = self.connection.raw_get(URL_USERINFO.format(**params_path))
-
         return raise_error_from_response(data_raw, KeycloakGetError)
 
     def logout(self, refresh_token):
@@ -304,11 +301,9 @@ class KeycloakOpenID:
         """
         params_path = {"realm-name": self.realm_name}
         payload = {"client_id": self.client_id, "refresh_token": refresh_token}
-
         payload = self._add_secret_key(payload)
         data_raw = self.connection.raw_post(URL_LOGOUT.format(**params_path), data=payload)
-
-        return raise_error_from_response(data_raw, KeycloakGetError, expected_codes=[204])
+        return raise_error_from_response(data_raw, KeycloakPostError, expected_codes=[204])
 
     def certs(self):
         """
@@ -367,7 +362,6 @@ class KeycloakOpenID:
         :return:
         """
         params_path = {"realm-name": self.realm_name}
-
         payload = {"client_id": self.client_id, "token": token}
 
         if token_type_hint == "requesting_party_token":
@@ -380,8 +374,7 @@ class KeycloakOpenID:
         payload = self._add_secret_key(payload)
 
         data_raw = self.connection.raw_post(URL_INTROSPECT.format(**params_path), data=payload)
-
-        return raise_error_from_response(data_raw, KeycloakGetError)
+        return raise_error_from_response(data_raw, KeycloakPostError)
 
     def decode_token(self, token, key, algorithms=["RS256"], **kwargs):
         """
@@ -399,7 +392,6 @@ class KeycloakOpenID:
         :param algorithms:
         :return:
         """
-
         return jwt.decode(token, key, algorithms=algorithms, audience=self.client_id, **kwargs)
 
     def load_authorization_config(self, path):
@@ -409,10 +401,10 @@ class KeycloakOpenID:
         :param path: settings file (json)
         :return:
         """
-        authorization_file = open(path, "r")
-        authorization_json = json.loads(authorization_file.read())
+        with open(path, "r") as fp:
+            authorization_json = json.load(fp)
+
         self.authorization.load_config(authorization_json)
-        authorization_file.close()
 
     def get_policies(self, token, method_token_info="introspect", **kwargs):
         """
@@ -421,7 +413,6 @@ class KeycloakOpenID:
         :param token: user token
         :return: policies list
         """
-
         if not self.authorization.policies:
             raise KeycloakAuthorizationConfigError(
                 "Keycloak settings not found. Load Authorization Keycloak settings."
@@ -455,7 +446,6 @@ class KeycloakOpenID:
         :param kwargs: parameters for decode
         :return: permissions list
         """
-
         if not self.authorization.policies:
             raise KeycloakAuthorizationConfigError(
                 "Keycloak settings not found. Load Authorization Keycloak settings."
@@ -493,7 +483,6 @@ class KeycloakOpenID:
         :param permissions: list of uma permissions list(resource:scope) requested by the user
         :return: permissions list
         """
-
         permission = build_permission_param(permissions)
 
         params_path = {"realm-name": self.realm_name}

tests/test_keycloak_admin.py

@@ -1731,7 +1731,7 @@ def test_auto_refresh(admin: KeycloakAdmin, realm: str):
         verify=admin.verify,
     )
     admin.token["refresh_token"] = "bad"
-    with pytest.raises(KeycloakGetError) as err:
+    with pytest.raises(KeycloakPostError) as err:
         admin.get_realm(realm_name="test-refresh")
     assert err.match(
         '400: b\'{"error":"invalid_grant","error_description":"Invalid refresh token"}\''