You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

86 lines
3.0 KiB

  1. # Contributing
  2. Welcome to the Python Keycloak contributing guidelines. We are all more than happy to receive
  3. any contributions to the repository and want to thank you in advance for your contributions!
  4. This document outlines the process and the guidelines on how contributions work for this repository.
  5. ## Setting up the dev environment
  6. The development environment is mainly up to the developer. Our recommendations are to create a python
  7. virtual environment and install the necessary requirements. Example
  8. ```sh
  9. python -m venv venv
  10. source venv/bin/activate
  11. python -m pip install -U pip
  12. python -m pip install -r requirements.txt
  13. python -m pip install -r dev-requirements.txt
  14. ```
  15. ## Running checks and tests
  16. We're utilizing `tox` for most of the testing workflows. However we also have an external dependency on `docker`.
  17. We're using docker to spin up a local keycloak instance which we run our test cases against. This is to avoid
  18. a lot of unnecessary mocking and yet have immediate feedback from the actual Keycloak instance. All of the setup
  19. is done for you with the tox environments, all you need is to have both tox and docker installed
  20. (`tox` is included in the `dev-requirements.txt`).
  21. To run the unit tests, simply run
  22. ```sh
  23. tox -e tests
  24. ```
  25. The project is also adhering to strict linting (flake8) and formatting (black + isort). You can always check that
  26. your code changes adhere to the format by running
  27. ```sh
  28. tox -e check
  29. ```
  30. If the check fails, you'll see an error message specifying what went wrong. To simplify things, you can also run
  31. ```sh
  32. tox -e apply-check
  33. ```
  34. which will apply isort and black formatting for you in the repository. The flake8 problems however need to be resolved
  35. manually by the developer.
  36. Additionally we require that the documentation pages are built without warnings. This check is also run via tox, using
  37. the command
  38. ```sh
  39. tox -e docs
  40. ```
  41. The check is also run in the CICD pipelines. We require that the documentation pages built from the code docstrings
  42. do not create visually "bad" pages.
  43. ## Conventional commits
  44. Commits to this project must adhere to the [Conventional Commits
  45. specification](https://www.conventionalcommits.org/en/v1.0.0/) that will allow
  46. us to automate version bumps and changelog entry creation.
  47. After cloning this repository, you must install the pre-commit hook for
  48. conventional commits (this is included in the `dev-requirements.txt`)
  49. ```sh
  50. python3 -m venv .venv
  51. source .venv/bin/activate
  52. python3 -m pip install pre-commit
  53. pre-commit install --install-hooks -t pre-commit -t pre-push -t commit-msg
  54. ```
  55. ## How to contribute
  56. 1. Fork this repository, develop and test your changes
  57. 2. Make sure that your changes do not decrease the test coverage
  58. 3. Make sure you're commits follow the conventional commits
  59. 4. Submit a pull request
  60. ## How to release
  61. The CICD pipelines are set up for the repository. When a PR is merged, a new version of the library
  62. will be automatically deployed to the PyPi server, meaning you'll be able to see your changes immediately.