From 967707723a0a8c6ec1b6a18af255e01e616722ef Mon Sep 17 00:00:00 2001 From: gorhill Date: Wed, 29 Oct 2014 09:27:11 -0400 Subject: [PATCH] this fixes #24 --- src/js/popup.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/js/popup.js b/src/js/popup.js index cbeb57b..411199a 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -393,6 +393,11 @@ function handleFilter(button, leaning) { var cell = button.ancestors('div.matCell'); var type = cell.prop('reqType'); var desHostname = cell.prop('hostname'); + // https://github.com/gorhill/uMatrix/issues/24 + // No hostname can happen -- like with blacklist meta row + if ( desHostname === '' ) { + return; + } var request = { what: getCellAction(desHostname, type, leaning), srcHostname: matrixSnapshot.scope, @@ -605,7 +610,12 @@ function makeMatrixMetaRowDomain(domain) { /******************************************************************************/ function renderMatrixMetaCellType(cell, count) { - cell.addClass('t1'); + // https://github.com/gorhill/uMatrix/issues/24 + // Don't forget to reset cell properties + cell.addClass('t1') + .prop('reqType', '') + .prop('hostname', '') + .prop('count', count); if ( count ) { cell.text(count); }