From 58c546ae082ae645466052cd021d6a83390f2973 Mon Sep 17 00:00:00 2001 From: gorhill Date: Fri, 20 Mar 2015 23:37:43 -0400 Subject: [PATCH] #1051: test only root frames --- platform/chromium/vapi-background.js | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/platform/chromium/vapi-background.js b/platform/chromium/vapi-background.js index 1a2ac57..5c316f8 100644 --- a/platform/chromium/vapi-background.js +++ b/platform/chromium/vapi-background.js @@ -141,16 +141,20 @@ vAPI.tabs.registerListeners = function() { }; var onBeforeNavigate = function(details) { - //console.debug('onBeforeNavigate: popup candidate', details.tabId); - popupCandidateTest(details); + if ( details.frameId === 0 ) { + //console.debug('onBeforeNavigate: popup candidate', details.tabId); + popupCandidateTest(details); + } }; var onCommitted = function(details) { - //console.debug('onCommitted: popup candidate', details.tabId); - if ( popupCandidateTest(details) === true ) { - return; + if ( details.frameId === 0 ) { + //console.debug('onCommitted: popup candidate', details.tabId); + if ( popupCandidateTest(details) === true ) { + return; + } + popupCandidateDestroy(details); } - popupCandidateDestroy(details); onNavigationClient(details); };