From 93cedabe9c1c32d56c21156b5de4a86275e0cbde Mon Sep 17 00:00:00 2001 From: Antonio SJ Musumeci Date: Thu, 22 Oct 2015 17:26:51 -0400 Subject: [PATCH] fix misc issues flagged by clang scan-build --- src/fs.cpp | 2 +- src/gidcache.cpp | 2 +- src/option_parser.cpp | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/fs.cpp b/src/fs.cpp index b86b692b..54a53d17 100644 --- a/src/fs.cpp +++ b/src/fs.cpp @@ -104,7 +104,7 @@ namespace fs vector &strs) { int flags; - glob_t gbuf; + glob_t gbuf = {0}; flags = 0; for(size_t i = 0; i < patterns.size(); i++) diff --git a/src/gidcache.cpp b/src/gidcache.cpp index 4a4cd765..8a280f51 100644 --- a/src/gidcache.cpp +++ b/src/gidcache.cpp @@ -110,7 +110,7 @@ gid_t_cache::cache(const uid_t uid, if(pwdrv != NULL && rv == 0) { rec->size = 0; - rv = ::getgrouplist(pwd.pw_name,gid,NULL,&rec->size); + ::getgrouplist(pwd.pw_name,gid,NULL,&rec->size); rec->size = std::min(MAXGIDS,rec->size); rv = ::getgrouplist(pwd.pw_name,gid,rec->gids,&rec->size); if(rv == -1) diff --git a/src/option_parser.cpp b/src/option_parser.cpp index ae1e54cf..e7c9b4cf 100644 --- a/src/option_parser.cpp +++ b/src/option_parser.cpp @@ -196,7 +196,6 @@ process_opt(Config &config, int rv; std::vector argvalue; - rv = 1; str::split(argvalue,arg,'='); switch(argvalue.size()) {