Mirror
/
go-neb
mirror of https://github.com/matrix-org/go-neb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
40 Commits
120 Branches
3 Tags
12 MiB
 
 
 
Branch: kegan/auth-session
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'kegan/auth-session'
${ noResults }
go-neb/design-notes.md

1.2 KiB
Raw Permalink Blame History

Random TODOs as I think of them:

  • Whilst the Expansions bit on plugins is a lovely surprise, I find myself having to run the regexp twice because the callback does not give me any captured groups (just the matched string). I run it once so the callback fires, then run it again to actually extract the useful bits. This could be done better.

  • I'm not sure about the Plugin(roomId string) interface function. Python NEB could be configured to allow certain actions in certain rooms (e.g. only expand issues in this room, not that room). You can for sure do that using the given interface function, but you'd need to store those mappings yourself. Python NEB did it by giving you a key-value store which you could chuck config info for a room into: I wonder how useful that would be for Go-NEB?

  • The service ID as it stands feels mingy. There are times I want to execute Service code without knowing a service ID (e.g. processing webhooks, executing auth code, etc) so I have to use "" just to create a Service :( Also, it feels wrong to defer responsibility for knowing what a valid service ID is to the caller of the /configureService API. How the hell do they know which IDs have been taken?!