go-neb

Commit Graph

Author	SHA1	Message	Date
Kegan Dougal	7522ddf1a4	Explain why no ParseURL	8 years ago
Kegan Dougal	c4e98238d8	uniq prior to length checks for accuracy	8 years ago
Kegan Dougal	1722871345	Don't use gofeed.ParseURL It leaks the response because it doesn't close the `resp.Body` on non-2xx.	8 years ago
Kegan Dougal	332b451d77	Redo how recent GUIDs are calculated This is an attempt to fix #133. Previously, we just clobbered the recent GUIDs with the lastest response every single time, assuming that Atom/RSS feeds would consistently return the same items. This appears to not be the case. In the wild, the number of items returned on a single request can vary (sometimes even being 1 or 2 when usually it is 50!). This patch alters how many and which GUIDs we keep between requests, in an attempt to prevent sending old news for buggy RSS feeds.	8 years ago
Kegan Dougal	d128ed2626	Add more logging for RSS feeds	8 years ago
Kegsay	357abef22c	Merge pull request #134 from matrix-org/kegan/rss-dont-replace-if-no-guids Treat RSS feeds with 0 items as errors	8 years ago
Kegan Dougal	677b556376	Return an error so it is logged	8 years ago
Kegan Dougal	66fb3253f7	Treat RSS feeds with 0 items as errors In the wild it looks like some RSS feeds will occasionally return 0 items to requests but not return an error. This previously meant we would clobber our knowledge of recent GUIDs with the empty set. This meant that the next successful poll would resend the entire RSS feed.	8 years ago
Kegsay	d7eb332948	Merge pull request #132 from matrix-org/kegan/giphy-translate-api Use Giphy's translate API for better accuracy	8 years ago
Kegan Dougal	729d004ad0	Use Giphy's translate API for better accuracy	8 years ago
Kegsay	f2383a89ac	Merge pull request #131 from matrix-org/kegan/finer-gh-controls Break apart 'issues' and 'pull_request' events	8 years ago
Kegan Dougal	aec58233d9	s/assign/assignments/	8 years ago
Kegan Dougal	4d918673c0	Break apart 'issues' and 'pull_request' events Now broken down into: - `labels` : Labelling/Unlabelling issues/PRs - `milestones` : Milestoning/Demilestoning issues/PRs - `assign` : Assigning/Unassigning issues/PRs This is broken down in the guts of parsing the webhook event such that it appears to be a unique `X-GitHub-Event` type.	8 years ago
Kegsay	402e29782a	Merge pull request #129 from matrix-org/kegan/testutils Add a dedicated testutils package	8 years ago
Kegan Dougal	683d36b5c5	Review comments	8 years ago
Kegsay	3055e2fd8d	Merge pull request #130 from matrix-org/kegan/smart-quotes Fix #72: Support smart quotes	8 years ago
Kegan Dougal	a9899557c5	Fix #72 : Support smart quotes	8 years ago
Kegan Dougal	7a382c8120	Add failing command parse tests	8 years ago
Kegan Dougal	8ec37a4cf9	Add a dedicated testutils package In the spirit of "if you have to do something 3 times then factor it out", make a testutils package to put all the `RoundTrip` boilerplate. I don't overly like having test packages, especially mixed in with code, but I don't see a nicer way of doing this without ending up with a sprawling mess of copypasta'd test boilerplate which will be an absolute nightmare to maintain. I think this is the lesser of two evils.	8 years ago
Kegsay	af32bdb4e3	Merge pull request #125 from matrix-org/kegan/github-say-which-labels Fix #105 : Mention which label was added/removed	8 years ago
Kegan Dougal	314db5f6c7	Fix #105 : Mention which label was added/removed	8 years ago
Kegsay	bde6fb10df	Merge pull request #122 from matrix-org/kegan/text-logging Use a text formatter which logs as key=val instead of JSON	8 years ago
Kegsay	16902074cf	Merge pull request #124 from matrix-org/kegan/dots-in-repos Allow '.' in owner/repo strings	8 years ago
Kegsay	aba9820844	Merge pull request #123 from matrix-org/kegan/case-insensitive-commands Fix #59 : Make pling commands case-insensitive	8 years ago
Kegan Dougal	085d3ecfd0	Allow '.' in owner/repo strings	8 years ago
Kegan Dougal	4a3431efbb	Fix #59 : Make pling commands case-insensitive	8 years ago
Kegan Dougal	14f49f2fde	Use a text formatter which logs as key=val instead of JSON We exclusively view logs using `less` and `tail`. These do not read JSON well. Logging as JSON makes it a PITA to read logs and debug problems. We do not appear to make use of JSON logging, and have no good terminal-based structured log viewer either. As a result, I've now removed JSON logging from this project and replaced it with the standard `TextFormatter` (colors off). This still logs in a structured way: ``` time="2016-11-18 16:25:46.787373" level=info msg="Got filter ID" filter=717 syncing=1 user_id="@goneb:localhost" time="2016-11-18 16:25:46.787525" level=info msg="Starting sync" next_batch="s26928_287972_2_1029_26_1_2" syncing=1 user_id="@goneb:localhost" ``` So we can still analyse logs sanely at a later date should we need to. This feels like the best compromise here between pragmatism and ideals.	8 years ago
Kegan Dougal	58df215ad6	Only emit travis results on success change	8 years ago
Kegsay	6bfcbfee18	Update README.md	8 years ago
Kegsay	ca24fb1955	Update README.md	8 years ago
Kegsay	182f0bbb6b	Add build badge	8 years ago
Kegan Dougal	07574c1f0d	Actually shorten the commit SHA	8 years ago
Kegan Dougal	2d61f5f186	Fix build	8 years ago
Kegan Dougal	45d167736d	Purposefully break build	8 years ago
Kegan Dougal	e8b2454b56	Kick travis	8 years ago
Kegan Dougal	9376c73838	Test travis config	8 years ago
Kegan Dougal	61c3110cfe	Fix travis-ci duration parsing The example from the docs was very clearly with spaces after hours and minutes: ``` "committed_at": "2011-11-11T11: 11: 11Z", ``` But in fact those spaces do not exist in the wild. Great.	8 years ago
Kegan Dougal	db5683d6f5	HACK: Have private/public fields for the webhook URL We can't just use a public field because the caller may clobber it. If they do clobber it, we've then lost the ability to set it back to what it was because we don't store another copy anywhere. This patch fixes it by keeping a private ref and always clobbering on Register(). This is horrible. We need to separate internal-storage and external-fields better.	8 years ago
Kegan Dougal	6ee73d5c49	lower_case_and_underscores webhook_url	8 years ago
Kegan Dougal	9b55ba9963	Travis: Join rooms on Register()	8 years ago
Kegsay	14cc43a6b5	Merge pull request #121 from matrix-org/kegan/travis Implement Travis-CI Service	8 years ago
Kegan Dougal	1d23f6bd94	Actually use the default and enable travisci service	8 years ago
Kegan Dougal	be52bdedf1	Clarify docs	8 years ago
Kegan Dougal	7f8c36ba89	Add a few more tests	8 years ago
Kegan Dougal	3a8b4a6aca	Add working test and implement template parsing	8 years ago
Kegan Dougal	4825c5c4ef	Begin to add Travis-CI Service tests Currently this verifies the signature logic, but not the templating logic which isn't implemented yet.	8 years ago
Kegan Dougal	5bf126473e	Verify incoming Travis-CI webhook requests	8 years ago
Kegan Dougal	6d297f63ad	Process Travis webhook events	8 years ago
Kegan Dougal	2b3cbba2e6	Begin to flesh out the Travis-CI service	8 years ago
Kegan Dougal	ff8b4c41d0	Add stub travis-ci service	8 years ago

... 2 3 4 5 6 ...

563 Commits (f5930000b23de04a30369f73e12d4a4f8f1b538c) All Branches Search

563 Commits (f5930000b23de04a30369f73e12d4a4f8f1b538c)

All Branches