go-neb

Commit Graph

Author	SHA1	Message	Date
Kegan Dougal	d128ed2626	Add more logging for RSS feeds	8 years ago
Kegan Dougal	677b556376	Return an error so it is logged	8 years ago
Kegan Dougal	66fb3253f7	Treat RSS feeds with 0 items as errors In the wild it looks like some RSS feeds will occasionally return 0 items to requests but not return an error. This previously meant we would clobber our knowledge of recent GUIDs with the empty set. This meant that the next successful poll would resend the entire RSS feed.	8 years ago
Kegan Dougal	729d004ad0	Use Giphy's translate API for better accuracy	8 years ago
Kegan Dougal	aec58233d9	s/assign/assignments/	8 years ago
Kegan Dougal	4d918673c0	Break apart 'issues' and 'pull_request' events Now broken down into: - `labels` : Labelling/Unlabelling issues/PRs - `milestones` : Milestoning/Demilestoning issues/PRs - `assign` : Assigning/Unassigning issues/PRs This is broken down in the guts of parsing the webhook event such that it appears to be a unique `X-GitHub-Event` type.	8 years ago
Kegan Dougal	683d36b5c5	Review comments	8 years ago
Kegan Dougal	a9899557c5	Fix #72 : Support smart quotes	8 years ago
Kegan Dougal	7a382c8120	Add failing command parse tests	8 years ago
Kegan Dougal	8ec37a4cf9	Add a dedicated testutils package In the spirit of "if you have to do something 3 times then factor it out", make a testutils package to put all the `RoundTrip` boilerplate. I don't overly like having test packages, especially mixed in with code, but I don't see a nicer way of doing this without ending up with a sprawling mess of copypasta'd test boilerplate which will be an absolute nightmare to maintain. I think this is the lesser of two evils.	8 years ago
Kegan Dougal	314db5f6c7	Fix #105 : Mention which label was added/removed	8 years ago
Kegan Dougal	085d3ecfd0	Allow '.' in owner/repo strings	8 years ago
Kegan Dougal	4a3431efbb	Fix #59 : Make pling commands case-insensitive	8 years ago
Kegan Dougal	14f49f2fde	Use a text formatter which logs as key=val instead of JSON We exclusively view logs using `less` and `tail`. These do not read JSON well. Logging as JSON makes it a PITA to read logs and debug problems. We do not appear to make use of JSON logging, and have no good terminal-based structured log viewer either. As a result, I've now removed JSON logging from this project and replaced it with the standard `TextFormatter` (colors off). This still logs in a structured way: ``` time="2016-11-18 16:25:46.787373" level=info msg="Got filter ID" filter=717 syncing=1 user_id="@goneb:localhost" time="2016-11-18 16:25:46.787525" level=info msg="Starting sync" next_batch="s26928_287972_2_1029_26_1_2" syncing=1 user_id="@goneb:localhost" ``` So we can still analyse logs sanely at a later date should we need to. This feels like the best compromise here between pragmatism and ideals.	8 years ago
Kegan Dougal	07574c1f0d	Actually shorten the commit SHA	8 years ago
Kegan Dougal	2d61f5f186	Fix build	8 years ago
Kegan Dougal	45d167736d	Purposefully break build	8 years ago
Kegan Dougal	61c3110cfe	Fix travis-ci duration parsing The example from the docs was very clearly with spaces after hours and minutes: ``` "committed_at": "2011-11-11T11: 11: 11Z", ``` But in fact those spaces do not exist in the wild. Great.	8 years ago
Kegan Dougal	db5683d6f5	HACK: Have private/public fields for the webhook URL We can't just use a public field because the caller may clobber it. If they do clobber it, we've then lost the ability to set it back to what it was because we don't store another copy anywhere. This patch fixes it by keeping a private ref and always clobbering on Register(). This is horrible. We need to separate internal-storage and external-fields better.	8 years ago
Kegan Dougal	6ee73d5c49	lower_case_and_underscores webhook_url	8 years ago
Kegan Dougal	9b55ba9963	Travis: Join rooms on Register()	8 years ago
Kegan Dougal	1d23f6bd94	Actually use the default and enable travisci service	8 years ago
Kegan Dougal	be52bdedf1	Clarify docs	8 years ago
Kegan Dougal	7f8c36ba89	Add a few more tests	8 years ago
Kegan Dougal	3a8b4a6aca	Add working test and implement template parsing	8 years ago
Kegan Dougal	4825c5c4ef	Begin to add Travis-CI Service tests Currently this verifies the signature logic, but not the templating logic which isn't implemented yet.	8 years ago
Kegan Dougal	5bf126473e	Verify incoming Travis-CI webhook requests	8 years ago
Kegan Dougal	6d297f63ad	Process Travis webhook events	8 years ago
Kegan Dougal	2b3cbba2e6	Begin to flesh out the Travis-CI service	8 years ago
Kegan Dougal	ff8b4c41d0	Add stub travis-ci service	8 years ago
Kegan Dougal	0b26e6330a	Add Guggy tests	8 years ago
Kegan Dougal	a1fa5c3cac	Add realm documentation - Add godoc for realms - Remove realm info from README	8 years ago
Kegan Dougal	6d65f77062	Use the right service type	8 years ago
Kegan Dougal	be3b4bc22c	Mention 'syncing client'	8 years ago
Kegan Dougal	7580d93042	400 if a service which needs a syncing client is configured without one This catches a common configuration error and fails early.	8 years ago
Kegan Dougal	a06ac2d3be	Make it clear that these are example requests	8 years ago
Kegan Dougal	209af79efe	Add example configs for each service	8 years ago
Kegan Dougal	f0cd6be741	Remove docs from the README and link to the godoc instead	8 years ago
Kegan Dougal	3fec1c6fa5	Add docs for all the remaining services and convert them to use NewDefaultService My hands hurt.	8 years ago
Kegan Dougal	41f73214ef	Add default implementations for ServiceType(), ServiceID() and ServiceUserID() In addition to making there be less boilerplate, this also has the nice side-effect of shutting up golint warnings \o/	8 years ago
Kegan Dougal	3e21e02171	Remove Plugin. Replace with Commands() and Expansions() Also split out `types.go` into separate files by the area they cover (services, auth, actions).	8 years ago
Kegan Dougal	6e396a95ef	Doc up Giphy service	8 years ago
Kegan Dougal	26f115d6f9	Appease golint	8 years ago
Kegan Dougal	c66fdd1bdb	Review comments	8 years ago
Kegan Dougal	81e1859cb4	Revert "Remove API docs from README which is duplicated" This reverts commit `f91f653704`.	8 years ago
Kegan Dougal	f91f653704	Remove API docs from README which is duplicated	8 years ago
Kegan Dougal	dc6d7c593a	Add lots of HTTP and API docs This all gets formatted right by godoc so we can point the README to that instead of having the docs so far away from the code.	8 years ago
Kegan Dougal	4ab61e4a5f	Split up the enormous handlers.go into more manageable files Split them up based on the HTTP API they are implementing.	8 years ago
Kegan Dougal	733440cf3d	GZip logs by default	8 years ago
Kegan Dougal	71e6d97f79	Remove outdated comment	8 years ago

1 2 3 4 5 ...

368 Commits (hs/search-usage)