Browse Source

Explain why no ParseURL

pull/136/head
Kegan Dougal 8 years ago
parent
commit
7522ddf1a4
  1. 1
      src/github.com/matrix-org/go-neb/services/rssbot/rssbot.go

1
src/github.com/matrix-org/go-neb/services/rssbot/rssbot.go

@ -371,6 +371,7 @@ func (rt userAgentRoundTripper) RoundTrip(req *http.Request) (*http.Response, er
} }
func readFeed(feedURL string) (*gofeed.Feed, error) { func readFeed(feedURL string) (*gofeed.Feed, error) {
// Don't use fp.ParseURL because it leaks on non-2xx responses as of 2016/11/29 (cac19c6c27)
fp := gofeed.NewParser() fp := gofeed.NewParser()
resp, err := cachingClient.Get(feedURL) resp, err := cachingClient.Get(feedURL)
if resp != nil { if resp != nil {

Loading…
Cancel
Save