From 5188df5d0edde82aa7a445bfc424b845fde1baed Mon Sep 17 00:00:00 2001
From: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Date: Thu, 9 May 2019 01:21:36 -0700
Subject: [PATCH] Don't mutate the passed in attribute
---
.../matrix-org/go-neb/services/rssbot/rssbot.go | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/github.com/matrix-org/go-neb/services/rssbot/rssbot.go b/src/github.com/matrix-org/go-neb/services/rssbot/rssbot.go
index d3622e5..0d1ad52 100644
--- a/src/github.com/matrix-org/go-neb/services/rssbot/rssbot.go
+++ b/src/github.com/matrix-org/go-neb/services/rssbot/rssbot.go
@@ -350,8 +350,10 @@ func (s *Service) sendToRooms(cli *gomatrix.Client, feedURL string, feed *gofeed
func itemToHTML(feed *gofeed.Feed, item gofeed.Item) gomatrix.HTMLMessage {
// If an item does not have a title, try using the feed's title instead
- if item.Title == "" {
- item.Title = feed.Title
+ // Create a new variable instead of mutating that which is passed in
+ itemTitle = item.Title
+ if itemTitle == "" {
+ itemTitle = feed.Title
}
return gomatrix.HTMLMessage{
@@ -360,7 +362,7 @@ func itemToHTML(feed *gofeed.Feed, item gofeed.Item) gomatrix.HTMLMessage {
MsgType: "m.notice",
Format: "org.matrix.custom.html",
FormattedBody: fmt.Sprintf("%s:
%s",
- html.EscapeString(feed.Title), html.EscapeString(item.Link), html.EscapeString(item.Title)),
+ html.EscapeString(feed.Title), html.EscapeString(item.Link), html.EscapeString(itemTitle)),
// FeedTitle:
//
// Title of the Entry