Before this, some deployment scripts would interact with STDIN and that would cause this loop to skip some elements. By using descriptor 3 we avoid clashing with the very common stdin and stdout.
Before this, the eval call would try to run some commands (if they were compound commands) in the yaml file on the machine running acme.sh
Eval might not be worth it for the little benefit it brings.
The config file checks were returning okay even when there were errors. The yq tool returns "null" when it cannot find what's queried, but exists with a 0 rc still.
- Prefer using a pipe to `while read`
- But use a temp file when the loop needs to modify variables that need to be used outside the loop, as the pipe creates a subshell and modifications do not survive after the loop exits.
Add support for deploying to the Zyxel GS1900 line of switches as long
as those switches are running at least firmware V2.80.
Tested on a Zyxel GS1900-8 and GS1900-24E
Resolves#5042
It was reported in issue #6267 that the private key was leaked when
using the DEPLOY_HAPROXY_HOT_UPDATE=yes feature.
Indeed, the debugging code which sends commands to HAProxy was using
_debug even when passing the private key.
This patch fixes the issue by using _secure_debug when doing that.
Jacobo de Vera
tomo
emueller
Joe Bauser
Attackwave
Alin Trăistaru
ms264556
William Lallemand
copyliu
Scruel Tao