As these are exported variables by convention they should be uppercase.
Travis/Spellcheck fails because they are not uppercase and it therefore
expects them to be defined or set before use.
Sometimes FreeDNS does not reurn the subdomain page but rather
returns a page regarding becoming a premium member. This usually
happens after a period of inactivity. Immediately trying again
returns the correct subdomain page. So, we will try twice to
load the page
Now the FREEDNS_USER and FREEDNS_PASSWORD need only be exported the first
time it is used and whenever the userid or password is changed. Subsequent
runs use the cookie cached in account.conf
As these are exported variables by convention they should be uppercase.
Travis/Spellcheck fails because they are not uppercase and it therefore
expects them to be defined or set before use.
Sometimes FreeDNS does not reurn the subdomain page but rather
returns a page regarding becoming a premium member. This usually
happens after a period of inactivity. Immediately trying again
returns the correct subdomain page. So, we will try twice to
load the page
Now the FREEDNS_USER and FREEDNS_PASSWORD need only be exported the first
time it is used and whenever the userid or password is changed. Subsequent
runs use the cookie cached in account.conf
message:
SC2034: $VARNAME appears unused. Verify it or export it.
most of these are related to the style:
we generate global vars, which are used in other functions.
the var "lexical_url" was really unused (left it as comment)
the travis-check now does not need anymore special flags.
Signed-off-by: Bastian Bittorf <bb@npl.de>
"Don't use [] around ranges in tr, it replaces literal square brackets."
this introduces another warning:
"Use '[:lower:]' to support accents and foreign alphabets."
This is more a style thingy because we really want to only catch A-Z.
work around this by using a shellcheck-directive and a comment
that the [:lower:] will not work with e.g. busybox-ash.
if we later really want to use [:lower:], we should use 'sed' for that.
David Kerr
neilpang
Bastian Bittorf
Kevin Kaland
Karsten Sperling
Paul Koppen