Browse Source

Fix DNSimple when zone has > 100 records

The _get_records function currently returns the first 100 records. As our TXT is added most recently, if you have > 100 records it will not be returned.

I've changed the function to sort by ID DESC, so it will always return the latest 100 records.
pull/1543/head
Grant Millar 7 years ago
committed by GitHub
parent
commit
e36fbd6af5
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      dnsapi/dns_dnsimple.sh

2
dnsapi/dns_dnsimple.sh

@ -152,7 +152,7 @@ _get_records() {
sub_domain=$3 sub_domain=$3
_debug "fetching txt records" _debug "fetching txt records"
_dnsimple_rest GET "$account_id/zones/$domain/records?per_page=100"
_dnsimple_rest GET "$account_id/zones/$domain/records?per_page=100&sort=id:desc"
if ! _contains "$response" "\"id\":"; then if ! _contains "$response" "\"id\":"; then
_err "failed to retrieve records" _err "failed to retrieve records"

Loading…
Cancel
Save