From cb113437f6aaafac06c456faacbd4c936181696c Mon Sep 17 00:00:00 2001
From: Gary McGregor <gary@kholin.org>
Date: Tue, 24 Sep 2024 07:23:39 -0500
Subject: [PATCH] Updating per comment re: Exit vs Return on initial validation

---
 dnsapi/dns_omglol.sh | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/dnsapi/dns_omglol.sh b/dnsapi/dns_omglol.sh
index 7f62b2d8..a77ddd15 100644
--- a/dnsapi/dns_omglol.sh
+++ b/dnsapi/dns_omglol.sh
@@ -39,6 +39,9 @@ dns_omglol_add() {
   _debug "omg.lol Address" "$omglol_address"
 
   omglol_validate "$omglol_apikey" "$omglol_address" "$fulldomain"
+  if [ ! $? ]; then
+    return 1
+  fi
 
   dnsName=$(_getDnsRecordName "$fulldomain" "$omglol_address")
   authHeader="$(_createAuthHeader "$omglol_apikey")"
@@ -66,6 +69,9 @@ dns_omglol_rm() {
   _debug address "$omglol_address"
 
   omglol_validate "$omglol_apikey" "$omglol_address" "$fulldomain"
+  if [ ! $? ]; then
+    return 1
+  fi
 
   dnsName=$(_getDnsRecordName "$fulldomain" "$omglol_address")
   authHeader="$(_createAuthHeader "$omglol_apikey")"
@@ -82,24 +88,24 @@ omglol_validate() {
 
   if [ "" = "$omglol_address" ]; then
     _err "omg.lol base address not provided.  Exiting"
-    exit 1
+    return 1
   fi
 
   if [ "" = "$omglol_apikey" ]; then
     _err "omg.lol API key not provided.  Exiting"
-    exit 1
+    return 1
   fi
 
   _endswith "$fulldomain" "omg.lol"
   if [ ! $? ]; then
     _err "Domain name requested is not under omg.lol"
-    exit 1
+    return 1
   fi
 
   _endswith "$fulldomain" "$omglol_address.omg.lol"
   if [ ! $? ]; then
     _err "Domain name is not a subdomain of provided omg.lol address $omglol_address"
-    exit 1
+    return 1
   fi
 
   _debug "omglol_validate(): Required environment parameters are all present"